-
Notifications
You must be signed in to change notification settings - Fork 30k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build: re-introduce --use-largepages as no-op #31075
Closed
gabrielschulhof
wants to merge
1
commit into
nodejs:master
from
gabrielschulhof:build-time-large-pages-noop
Closed
build: re-introduce --use-largepages as no-op #31075
gabrielschulhof
wants to merge
1
commit into
nodejs:master
from
gabrielschulhof:build-time-large-pages-noop
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
the
build
Issues and PRs related to build files or the CI.
label
Dec 24, 2019
The tests failed locally with
|
richardlau
approved these changes
Dec 24, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Commit title has a typo (“introducue”) but otherwise LGTM.
Re-introduce the build-time option as a no-op in order to retain backward compatibility for LTS purposes. Re: nodejs#31063 (review)
gabrielschulhof
force-pushed
the
build-time-large-pages-noop
branch
from
December 24, 2019 05:28
cbaa946
to
68880f4
Compare
gabrielschulhof
changed the title
build: re-introducue --use-largepages as no-op
build: re-introduce --use-largepages as no-op
Dec 24, 2019
@richardlau thanks! I fixed the commit message. |
BethGriggs
approved these changes
Dec 24, 2019
addaleax
approved these changes
Dec 24, 2019
cjihrig
approved these changes
Dec 24, 2019
BridgeAR
approved these changes
Dec 24, 2019
BridgeAR
added
the
author ready
PRs that have at least one approval, no pending requests for changes, and a CI started.
label
Dec 24, 2019
gabrielschulhof
pushed a commit
that referenced
this pull request
Dec 26, 2019
Re-introduce the build-time option as a no-op in order to retain backward compatibility for LTS purposes. Re: #31063 (review) PR_URL: #31075 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Beth Griggs <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]>
Landed in 3d50001. |
4 tasks
gabrielschulhof
pushed a commit
to gabrielschulhof/node
that referenced
this pull request
Dec 31, 2019
Re-introduce the build-time option as a no-op in order to retain backward compatibility for LTS purposes. Re: nodejs#31063 (review) PR_URL: nodejs#31075 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Beth Griggs <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]>
BridgeAR
pushed a commit
that referenced
this pull request
Jan 3, 2020
Re-introduce the build-time option as a no-op in order to retain backward compatibility for LTS purposes. Re: #31063 (review) PR_URL: #31075 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Beth Griggs <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]>
MylesBorins
pushed a commit
that referenced
this pull request
Jan 8, 2020
Re-introduce the build-time option as a no-op in order to retain backward compatibility for LTS purposes. Re: #31063 (review) Backport-PR-URL: #31063 PR_URL: #31075 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Beth Griggs <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]>
BethGriggs
pushed a commit
that referenced
this pull request
Feb 6, 2020
Re-introduce the build-time option as a no-op in order to retain backward compatibility for LTS purposes. Re: #31063 (review) Backport-PR-URL: #31063 PR_URL: #31075 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Beth Griggs <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]>
gabrielschulhof
pushed a commit
to gabrielschulhof/node
that referenced
this pull request
Mar 6, 2020
Re-introduce the build-time option as a no-op in order to retain backward compatibility for LTS purposes. Re: nodejs#31063 (review) PR_URL: nodejs#31075 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Beth Griggs <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]>
gabrielschulhof
pushed a commit
to gabrielschulhof/node
that referenced
this pull request
Apr 9, 2020
Re-introduce the build-time option as a no-op in order to retain backward compatibility for LTS purposes. Re: nodejs#31063 (review) PR_URL: nodejs#31075 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Beth Griggs <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]>
targos
added
backported-to-v12.x
and removed
author ready
PRs that have at least one approval, no pending requests for changes, and a CI started.
labels
Apr 25, 2020
targos
pushed a commit
to targos/node
that referenced
this pull request
Apr 25, 2020
Re-introduce the build-time option as a no-op in order to retain backward compatibility for LTS purposes. Backport-PR-URL: nodejs#32092 Re: nodejs#31063 (review) PR_URL: nodejs#31075 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Beth Griggs <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]>
targos
pushed a commit
that referenced
this pull request
Apr 28, 2020
Re-introduce the build-time option as a no-op in order to retain backward compatibility for LTS purposes. Backport-PR-URL: #32092 Re: #31063 (review) PR_URL: #31075 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Beth Griggs <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Re-introduce the build-time option as a no-op in order to retain
backward compatibility for LTS purposes.
Re: #31063 (review)
Checklist
make -j4 test
(UNIX), orvcbuild test
(Windows) passes