Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: remove spawn option for tmpdir.refresh() #30888

Closed
wants to merge 1 commit into from
Closed

test: remove spawn option for tmpdir.refresh() #30888

wants to merge 1 commit into from

Conversation

Trott
Copy link
Member

@Trott Trott commented Dec 10, 2019

Recent fixes to fs.rmdir({recursive: true}) (hopefully) make the spawn
option in our internal test tool unnecessary.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

@Trott
test: remove spawn option for tmpdir.refresh()
52e7bf1 
Recent fixes to fs.rmdir({recursive: true}) (hopefully) make the spawn
option in our internal test tool unnecessary.
@nodejs-github-bot nodejs-github-bot added async_hooks Issues and PRs related to the async hooks subsystem. test Issues and PRs related to the tests. labels Dec 10, 2019
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/27554/

@cjihrig
Copy link
Contributor

cjihrig commented Dec 10, 2019

Significant overlap with #30849?

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/27557/

@mmarchini mmarchini mentioned this pull request Dec 10, 2019
Closed
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/27565/

@Trott Trott closed this Dec 12, 2019
@Trott Trott deleted the rm-spawn branch December 12, 2019 19:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lpinca lpinca lpinca approved these changes

Assignees
No one assigned
Labels
async_hooks Issues and PRs related to the async hooks subsystem. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Trott @nodejs-github-bot @cjihrig @lpinca