Windows CI job update changes #30724

joaocgreis · 2019-11-30T02:47:10Z

The Windows CI job currently includes direct calls to cctest and test.py. Moving most of the logic back to vcbuild has been in our backlog since the change was made.

This became necessary now because I'm working on an update to the CI job that makes it work for all Node.js versions, if the vcbuild targets are there. I will open backport PRs to active branches.

The second commit fixes an issue where failures cctest make the job become yellow rather than red. Since this works with the new target, this will only apply to the new job.

Refs: nodejs/build#1996

cc @nodejs/build @nodejs/platform-windows

Checklist

make -j4 test (UNIX), or vcbuild test (Windows) passes
commit message follows commit guidelines

Don't exit vcbuild with error code 0 when cctest fails.

nodejs-github-bot · 2019-11-30T02:48:36Z

CI: https://ci.nodejs.org/job/node-test-pull-request/27198/

rvagg

I'm surprised that test-ci was deprecated and now removed, is this because we run fanned and don't need them together?

joaocgreis · 2019-12-02T15:58:46Z

I believe test-ci was deprecated for nodejs/build#1761, the logic moved to the Jenkins job. This brings it back to vcbuild.bat. There are two test-ci-* targets because we will have two test jobs (preview in https://ci.nodejs.org/job/reis-test-commit-windows-fanned/).

@nodejs/build @nodejs/platform-windows please take a look, we are not running CI at full capacity because some resources have already been re-organized to test, I need this to land to complete the work. Thanks!

Trott · 2019-12-02T16:39:14Z

Landed in 8c101de...3b484ed

PR-URL: #30724 Refs: nodejs/build#1996 Reviewed-By: Rod Vagg <[email protected]> Reviewed-By: Sam Roberts <[email protected]> Reviewed-By: Rich Trott <[email protected]>

Don't exit vcbuild with error code 0 when cctest fails. PR-URL: #30724 Refs: nodejs/build#1996 Reviewed-By: Rod Vagg <[email protected]> Reviewed-By: Sam Roberts <[email protected]> Reviewed-By: Rich Trott <[email protected]>

PR-URL: #30724 Refs: nodejs/build#1996 Reviewed-By: Rod Vagg <[email protected]> Reviewed-By: Sam Roberts <[email protected]> Reviewed-By: Rich Trott <[email protected]>

Don't exit vcbuild with error code 0 when cctest fails. PR-URL: #30724 Refs: nodejs/build#1996 Reviewed-By: Rod Vagg <[email protected]> Reviewed-By: Sam Roberts <[email protected]> Reviewed-By: Rich Trott <[email protected]>

Backport-PR-URL: #30726 PR-URL: #30724 Refs: nodejs/build#1996 Reviewed-By: Rod Vagg <[email protected]> Reviewed-By: Sam Roberts <[email protected]> Reviewed-By: Rich Trott <[email protected]>

Don't exit vcbuild with error code 0 when cctest fails. Backport-PR-URL: #30726 PR-URL: #30724 Refs: nodejs/build#1996 Reviewed-By: Rod Vagg <[email protected]> Reviewed-By: Sam Roberts <[email protected]> Reviewed-By: Rich Trott <[email protected]>

Backport-PR-URL: #30727 PR-URL: #30724 Refs: nodejs/build#1996 Reviewed-By: Rod Vagg <[email protected]> Reviewed-By: Sam Roberts <[email protected]> Reviewed-By: Rich Trott <[email protected]>

Don't exit vcbuild with error code 0 when cctest fails. Backport-PR-URL: #30727 PR-URL: #30724 Refs: nodejs/build#1996 Reviewed-By: Rod Vagg <[email protected]> Reviewed-By: Sam Roberts <[email protected]> Reviewed-By: Rich Trott <[email protected]>

PR-URL: #30724 Refs: nodejs/build#1996 Reviewed-By: Rod Vagg <[email protected]> Reviewed-By: Sam Roberts <[email protected]> Reviewed-By: Rich Trott <[email protected]>

Don't exit vcbuild with error code 0 when cctest fails. PR-URL: #30724 Refs: nodejs/build#1996 Reviewed-By: Rod Vagg <[email protected]> Reviewed-By: Sam Roberts <[email protected]> Reviewed-By: Rich Trott <[email protected]>

Backport-PR-URL: #30727 PR-URL: #30724 Refs: nodejs/build#1996 Reviewed-By: Rod Vagg <[email protected]> Reviewed-By: Sam Roberts <[email protected]> Reviewed-By: Rich Trott <[email protected]>

Backport-PR-URL: #30726 PR-URL: #30724 Refs: nodejs/build#1996 Reviewed-By: Rod Vagg <[email protected]> Reviewed-By: Sam Roberts <[email protected]> Reviewed-By: Rich Trott <[email protected]>

PR-URL: #30724 Refs: nodejs/build#1996 Reviewed-By: Rod Vagg <[email protected]> Reviewed-By: Sam Roberts <[email protected]> Reviewed-By: Rich Trott <[email protected]>

Don't exit vcbuild with error code 0 when cctest fails. PR-URL: #30724 Refs: nodejs/build#1996 Reviewed-By: Rod Vagg <[email protected]> Reviewed-By: Sam Roberts <[email protected]> Reviewed-By: Rich Trott <[email protected]>

Don't exit vcbuild with error code 0 when cctest fails. Backport-PR-URL: #30726 PR-URL: #30724 Refs: nodejs/build#1996 Reviewed-By: Rod Vagg <[email protected]> Reviewed-By: Sam Roberts <[email protected]> Reviewed-By: Rich Trott <[email protected]>

Don't exit vcbuild with error code 0 when cctest fails. Backport-PR-URL: #30727 PR-URL: #30724 Refs: nodejs/build#1996 Reviewed-By: Rod Vagg <[email protected]> Reviewed-By: Sam Roberts <[email protected]> Reviewed-By: Rich Trott <[email protected]>

Don't exit vcbuild with error code 0 when cctest fails. PR-URL: #30724 Refs: nodejs/build#1996 Reviewed-By: Rod Vagg <[email protected]> Reviewed-By: Sam Roberts <[email protected]> Reviewed-By: Rich Trott <[email protected]>

bnoordhuis · 2020-01-02T07:25:40Z

vcbuild.bat

@@ -86,8 +92,8 @@ if /i "%1"=="noetw"         set noetw=1&goto arg-ok
 if /i "%1"=="ltcg"          set ltcg=1&goto arg-ok
 if /i "%1"=="licensertf"    set licensertf=1&goto arg-ok
 if /i "%1"=="test"          set test_args=%test_args% -J %common_test_suites%&set lint_cpp=1&set lint_js=1&set lint_md=1&goto arg-ok
-:: test-ci is deprecated
-if /i "%1"=="test-ci"       goto arg-ok


The removal of the test-ci target breaks some of the CI jobs, see https://ci.nodejs.org/job/node-test-commit-windows/976/nodes=win10/console:

C:\workspace\node-test-commit-windows\nodes\win10>vcbuild.bat release nosign x64 test-ci ignore-flaky NODE_TEST_DIR=C:\node-tmp Note: vcbuild no longer signs by default. "nosign" is redundant. Error: invalid command line option `test-ci`.

(Apologies if it's already been reported. I searched nodejs/node and nodejs/build but didn't find an exact match.)

@bnoordhuis any reason not to use node-test-commit-windows-fanned instead? node-test-commit-windows has been forgotten for a long time, I'll archive it if there's no objection.

Note that test-ci was a no-op as removed here, running with it only compiled, did not run tests.

Ah, if it's unmaintained then yes, please remove or archive it to avoid confusion. :-)

joaocgreis added 2 commits November 29, 2019 02:36

build,win: add test-ci-native and test-ci-js

6977a61

build,win: propagate error codes in vcbuild

5fbd4cf

Don't exit vcbuild with error code 0 when cctest fails.

nodejs-github-bot added build Issues and PRs related to build files or the CI. windows Issues and PRs related to the Windows platform. labels Nov 30, 2019

This was referenced Nov 30, 2019

[v12.x backport] Windows CI job update changes #30725

Closed

[v10.x backport] Windows CI job update changes #30726

Closed

[v8.x backport] Windows CI job update changes #30727

Closed

rvagg approved these changes Dec 2, 2019

View reviewed changes

sam-github approved these changes Dec 2, 2019

View reviewed changes

Trott added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Dec 2, 2019

Trott approved these changes Dec 2, 2019

View reviewed changes

Trott pushed a commit that referenced this pull request Dec 2, 2019

build,win: add test-ci-native and test-ci-js

001d250

PR-URL: #30724 Refs: nodejs/build#1996 Reviewed-By: Rod Vagg <[email protected]> Reviewed-By: Sam Roberts <[email protected]> Reviewed-By: Rich Trott <[email protected]>

Trott closed this Dec 2, 2019

targos pushed a commit that referenced this pull request Dec 3, 2019

build,win: add test-ci-native and test-ci-js

6a53152

PR-URL: #30724 Refs: nodejs/build#1996 Reviewed-By: Rod Vagg <[email protected]> Reviewed-By: Sam Roberts <[email protected]> Reviewed-By: Rich Trott <[email protected]>

BridgeAR mentioned this pull request Dec 3, 2019

v13.3.0 proposal #30774

Merged

BethGriggs mentioned this pull request Dec 4, 2019

v10.18.1 proposal #30796

Closed

targos pushed a commit that referenced this pull request Dec 5, 2019

build,win: add test-ci-native and test-ci-js

8dd5eec

PR-URL: #30724 Refs: nodejs/build#1996 Reviewed-By: Rod Vagg <[email protected]> Reviewed-By: Sam Roberts <[email protected]> Reviewed-By: Rich Trott <[email protected]>

BethGriggs mentioned this pull request Dec 9, 2019

v12.13.2 proposal #30865

Closed

BethGriggs mentioned this pull request Dec 23, 2019

v12.14.1 proposal #31069

Merged

bnoordhuis reviewed Jan 2, 2020

View reviewed changes

bnoordhuis mentioned this pull request Jan 2, 2020

v8: include right headers in torque output nodejs/node-v8#133

Closed

BethGriggs mentioned this pull request Jan 7, 2020

v10.18.1 proposal #31248

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Windows CI job update changes #30724

Windows CI job update changes #30724

joaocgreis commented Nov 30, 2019

nodejs-github-bot commented Nov 30, 2019

rvagg left a comment

joaocgreis commented Dec 2, 2019

Trott commented Dec 2, 2019

bnoordhuis Jan 2, 2020

joaocgreis Jan 2, 2020

bnoordhuis Jan 3, 2020

Windows CI job update changes #30724

Windows CI job update changes #30724

Conversation

joaocgreis commented Nov 30, 2019

Checklist

nodejs-github-bot commented Nov 30, 2019

rvagg left a comment

Choose a reason for hiding this comment

joaocgreis commented Dec 2, 2019

Trott commented Dec 2, 2019

bnoordhuis Jan 2, 2020

Choose a reason for hiding this comment

joaocgreis Jan 2, 2020

Choose a reason for hiding this comment

bnoordhuis Jan 3, 2020

Choose a reason for hiding this comment