esm: data URLs should ignore unknown parameters #30593
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bmeck
added
experimental
jkrems
approved these changes
Nov 22, 2019
|
For reference (from the original PR) — https://gist.github.com/SMotaal/2e0ede8c6115b828c111fa84a1e952b4 |
bmeck
force-pushed
the
esm-data-url-params
branch
from
415695b to
2495ac6
Compare
bmeck
force-pushed
the
esm-data-url-params
branch
from
2495ac6 to
7a6a6db
Compare
|
CI error is on waiting for AIX executor timeout, looks good to merge in a few |
bmeck
pushed a commit
that referenced
this pull request
Nov 26, 2019
PR-URL: #30593 Reviewed-By: Jan Krems <[email protected]> Reviewed-By: Guy Bedford <[email protected]>
|
Landed in 568968e |
addaleax
pushed a commit
that referenced
this pull request
Nov 30, 2019
PR-URL: #30593 Reviewed-By: Jan Krems <[email protected]> Reviewed-By: Guy Bedford <[email protected]>
Merged
MylesBorins
pushed a commit
that referenced
this pull request
Jan 12, 2020
PR-URL: #30593 Reviewed-By: Jan Krems <[email protected]> Reviewed-By: Guy Bedford <[email protected]>
BethGriggs
pushed a commit
that referenced
this pull request
Feb 6, 2020
PR-URL: #30593 Reviewed-By: Jan Krems <[email protected]> Reviewed-By: Guy Bedford <[email protected]>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
data:URL implementation was overly strict about what MIMEs it accepted. This caused problems for people using parameters. This relaxes the restrictions and follows the MIME expectation of ignoring unknown parameters. Per RFC2045:This also matches the WHATWG handling of
data:URLs by using any,as the splitting point.CC: @nodejs/modules
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes