crypto: Add more keylen sanity checks in pbkdf2 #3029
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @bnoordhuis |
johannhof
force-pushed
the
pbkdf2-fail-on-nan
branch
2 times, most recently
from
b9eaa43 to
d9d05fc
Compare
|
/cc @nodejs/collaborators - can I have one more LGTM? |
bnoordhuis
added
confirmed-bug
| crypto.pbkdf2('password', 'salt', 1, NaN, assert.fail); | ||
| }); | ||
|
|
||
| // Should not work with NaN key length |
|
One minor nit, otherwise LGTM |
| // Should not work with Infinity key length | ||
| assert.throws(function() { | ||
| crypto.pbkdf2('password', 'salt', 1, Infinity, assert.fail); | ||
| }); |
There was a problem hiding this comment.
Check at least the type of error.
|
LGTM, except nits from @thefourtheye |
issue nodejs#2987 makes the point that crypto.pbkdf2 should not fail silently and accept invalid but numeric values like NaN and Infinity. We already check if the keylen is lower than 0, so extending that to NaN and Infinity should make sense. Fixes: nodejs#2987
johannhof
force-pushed
the
pbkdf2-fail-on-nan
branch
from
d9d05fc to
5550518
Compare
|
@indutny @thefourtheye @mscdex @bnoordhuis Updated, thanks for the remarks :) |
|
LGTM |
|
@bnoordhuis wanna merge? :) |
thefourtheye
pushed a commit
that referenced
this pull request
Sep 25, 2015
issue #2987 makes the point that crypto.pbkdf2 should not fail silently and accept invalid but numeric values like NaN and Infinity. We already check if the keylen is lower than 0, so extending that to NaN and Infinity should make sense. Fixes: #2987 PR-URL: #3029 Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Brian White <[email protected]> Reviewed-By: Fedor Indutny <[email protected]> Reviewed-By: Sakthipriyan Vairamani <[email protected]>
|
Thanks @johannhof :-) Landed in 6df47d6 |
rvagg
pushed a commit
that referenced
this pull request
Sep 30, 2015
issue #2987 makes the point that crypto.pbkdf2 should not fail silently and accept invalid but numeric values like NaN and Infinity. We already check if the keylen is lower than 0, so extending that to NaN and Infinity should make sense. Fixes: #2987 PR-URL: #3029 Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Brian White <[email protected]> Reviewed-By: Fedor Indutny <[email protected]> Reviewed-By: Sakthipriyan Vairamani <[email protected]>
This was referenced Sep 30, 2015
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
issue #2987 makes the point that crypto.pbkdf2 should not fail silently
and accept invalid but numeric values like NaN and Infinity. We already
check if the keylen is lower than 0, so extending that to NaN and
Infinity should make sense.
Fixes: #2987