url: replace var with let in lib/url.js #30281
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
the
url
ChALkeR
added
the
code-and-learn
BridgeAR
approved these changes
Nov 6, 2019
trivikr
approved these changes
Nov 6, 2019
| let end = -1; | ||
| let rest = ''; | ||
| let lastPos = 0; | ||
| let i = 0; |
There was a problem hiding this comment.
nit: move i = 0 inside the loop on line 166
Also, add let in a for loop on line 298 and 414?
for (let i = 0; i < rest.length; ++i) {| var hostEnd = -1; | ||
| var atSign = -1; | ||
| var nonHost = -1; | ||
| let hostEnd = -1; |
There was a problem hiding this comment.
nit: the variable hostEnd can move inside the loop
|
@trivikr - are your suggestions a blocker from landing? plmk. |
@gireeshpunathil Nope, they're not a blocker. It's optional for @xefimx to follow-up if they want. |
2 tasks
Trott
pushed a commit
that referenced
this pull request
Nov 17, 2019
PR-URL: #30281 Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]>
|
Landed in 87cef76 |
|
Thanks for the contribution! 🎉 |
2 tasks
MylesBorins
pushed a commit
that referenced
this pull request
Nov 17, 2019
PR-URL: #30281 Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]>
Merged
targos
pushed a commit
that referenced
this pull request
Dec 1, 2019
PR-URL: #30281 Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]>
trivikr
added a commit
to trivikr/node
that referenced
this pull request
Dec 7, 2019
Closed
bmeck
pushed a commit
that referenced
this pull request
Dec 11, 2019
Refs: #30281 (comment) PR-URL: #30509 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]>
MylesBorins
pushed a commit
that referenced
this pull request
Dec 13, 2019
Refs: #30281 (comment) PR-URL: #30509 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]>
MylesBorins
pushed a commit
that referenced
this pull request
Dec 17, 2019
PR-URL: #30281 Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]>
Merged
targos
pushed a commit
that referenced
this pull request
Jan 14, 2020
Refs: #30281 (comment) PR-URL: #30509 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]>
BethGriggs
pushed a commit
that referenced
this pull request
Feb 6, 2020
Refs: #30281 (comment) PR-URL: #30509 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
url: replace var with let and const in lib/url.js
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes