src: add file name to 'Module did not self-register' error #30125
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
the
c++
addaleax
approved these changes
Oct 25, 2019
devsnek
reviewed
Oct 25, 2019
| @@ -484,7 +484,9 @@ void DLOpen(const FunctionCallbackInfo<Value>& args) { | |||
| mp = dlib->GetSavedModuleFromGlobalHandleMap(); | |||
| if (mp == nullptr || mp->nm_context_register_func == nullptr) { | |||
| dlib->Close(); | |||
| env->ThrowError("Module did not self-register."); | |||
| char errmsg[1024]; | |||
There was a problem hiding this comment.
PATH_MAX + strlen("Module did not self-register.") + 1 i suppose?
given the code immediately below that also uses 1024 and includes *filename, I figured best to go for consistency :)
cjihrig
approved these changes
Oct 26, 2019
devnexen
approved these changes
Oct 26, 2019
addaleax
added
addons
tniessen
approved these changes
Oct 30, 2019
|
Looks like the CI flaked out here, could someone kick it? |
|
Landed in 4f43418 🎉 |
addaleax
pushed a commit
that referenced
this pull request
Nov 19, 2019
PR-URL: #30125 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: David Carlier <[email protected]> Reviewed-By: Tobias Nießen <[email protected]>
MylesBorins
pushed a commit
that referenced
this pull request
Nov 21, 2019
PR-URL: #30125 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: David Carlier <[email protected]> Reviewed-By: Tobias Nießen <[email protected]>
Merged
targos
pushed a commit
that referenced
this pull request
Dec 1, 2019
PR-URL: #30125 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: David Carlier <[email protected]> Reviewed-By: Tobias Nießen <[email protected]>
Closed
MylesBorins
pushed a commit
that referenced
this pull request
Dec 17, 2019
PR-URL: #30125 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: David Carlier <[email protected]> Reviewed-By: Tobias Nießen <[email protected]>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The 'Module did not self-register' error can be difficult to track down because it's not always obvious which module is failing to self-register.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes