cli: add --trace-uncaught flag #30025

addaleax · 2019-10-18T15:22:47Z

Add a flag that makes Node.js print the stack trace at the
time of throwing uncaught exceptions, rather than at the
creation of the Error object, if there is any.

This is disabled by default because it affects GC behavior.

Checklist

make -j4 test (UNIX), or vcbuild test (Windows) passes
tests and/or benchmarks are included
documentation is changed or added
commit message follows commit guidelines

Add a flag that makes Node.js print the stack trace at the time of *throwing* uncaught exceptions, rather than at the creation of the `Error` object, if there is any. This is disabled by default because it affects GC behavior.

nodejs-github-bot · 2019-10-18T15:25:01Z

CI: https://ci.nodejs.org/job/node-test-pull-request/26094/

gireeshpunathil · 2019-10-18T17:05:58Z

@addaleax - can you please throw more light on what behavior change it causes to gc?

addaleax · 2019-10-18T17:54:25Z

@gireeshpunathil As far as I could tell, it makes functions keep alive stack frames which in turn keep objects that were present in those stack frames alive -- V8 doesn't really document this or what other impact it might have.

You can try it for yourself by enabling this flag by default and running the test suite, some tests that use GC will fail.

gireeshpunathil · 2019-10-19T11:14:32Z

@addaleax - I ran the gc tests, but did not see any failures (in osx).

Probably this is not a cause of worry for real applications (that do not depend on exact timing and order of objects being collected)?

addaleax · 2019-10-19T12:07:26Z

@gireeshpunathil

$ ./node --expose-gc --trace-uncaught test/parallel/test-zlib-invalid-input-memory.js
Mismatched noop function calls. Expected exactly 1, actual 0.
    at Object.mustCall (/home/sqrt/src/node/test/common/index.js:337:10)
    at Object.<anonymous> (/home/sqrt/src/node/test/parallel/test-zlib-invalid-input-memory.js:11:21)
[...]

I think static functions that hold on to dynamic data that was passed to them qualifies as a memory leak (even if its size is limited), and I wouldn’t feel comfortable turning this flag on by default (at least not without further research).

nodejs-github-bot · 2019-10-21T12:16:03Z

CI: https://ci.nodejs.org/job/node-test-pull-request/26134/

danbev · 2019-10-22T06:34:08Z

Landed in 31217a8.

Add a flag that makes Node.js print the stack trace at the time of *throwing* uncaught exceptions, rather than at the creation of the `Error` object, if there is any. This is disabled by default because it affects GC behavior. PR-URL: #30025 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]>

Notable changes: * cli: * Added a new flag (`--trace-uncaught`) that makes Node.js print the stack trace at the time of throwing uncaught exceptions, rather than at the creation of the `Error` object, if there is any. This is disabled by default because it affects GC behavior. #30025 * crypto * Added `Hash.prototype.copy()` method. It returns a new `Hash` object with its internal state cloned from the original one. #29910 * dgram * Added source-specific multicast support. This adds methods to Datagram sockets to support RFC 4607 (https://tools.ietf.org/html/rfc4607) for IPv4 and IPv6. #15735 * fs * Added a `bufferSize` option to `fs.opendir()`. It allows to control the number of entries that are buffered internally when reading from the directory. #30114 * meta * Added Chengzhong Wu (https://github.com/legendecas) to collaborators. #30115 PR-URL: #30262

Add a flag that makes Node.js print the stack trace at the time of *throwing* uncaught exceptions, rather than at the creation of the `Error` object, if there is any. This is disabled by default because it affects GC behavior. PR-URL: #30025 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]>

Notable changes: New assert APIs The `assert` module now provides experimental `assert.match()` and `assert.doesNotMatch()` methods. They will validate that the first argument is a string and matches (or does not match) the provided regular expression This is an experimental feature. Ruben Bridgewater [#30929](#30929). Advanced serialization for IPC The `child_process` and `cluster` modules now support a `serialization` option to change the serialization mechanism used for IPC. The option can have one of two values: * `'json'` (default): `JSON.stringify()` and `JSON.parse()` are used. This is how message serialization was done before. * `'advanced'`: The serialization API of the `v8` module is used. It is based on the HTML structured clone algorithm. and is able to serialize more built-in JavaScript object types, such as `BigInt`, `Map`, `Set` etc. as well as circular data structures. Anna Henningsen [#30162](#30162). CLI flags The new `--trace-exit` CLI flag makes Node.js print a stack trace whenever the Node.js environment is exited proactively (i.e. by invoking the `process.exit()` function or pressing Ctrl+C). legendecas [#30516](#30516). ___ The new `--trace-uncaught` CLI flag makes Node.js print a stack trace at the time of throwing uncaught exceptions, rather than at the creation of the `Error` object, if there is any. This option is not enabled by default because it may affect garbage collection behavior negatively. Anna Henningsen [#30025](#30025). ___ The `--disallow-code-generation-from-strings` V8 CLI flag is now whitelisted in the `NODE_OPTIONS` environment variable. Shelley Vohr [#30094](#30094). New crypto APIs For DSA and ECDSA, a new signature encoding is now supported in addition to the existing one (DER). The `verify` and `sign` methods accept a `dsaEncoding` option, which can have one of two values: * `'der'` (default): DER-encoded ASN.1 signature structure encoding `(r, s)`. * `'ieee-p1363'`: Signature format `r || s` as proposed in IEEE-P1363. Tobias Nießen [#29292](#29292). ___ A new method was added to `Hash`: `Hash.prototype.copy`. It makes it possible to clone the internal state of a `Hash` object into a new `Hash` object, allowing to compute the digest between updates. Ben Noordhuis [#29910](#29910). Dependency updates libuv was updated to 1.34.0. This includes fixes to `uv_fs_copyfile()` and `uv_interface_addresses()` and adds two new functions: `uv_sleep()` and `uv_fs_mkstemp()`. Colin Ihrig [#30783](#30783). ___ V8 was updated to 7.8.279.23. This includes performance improvements to object destructuring, RegExp match failures and WebAssembly startup time. The official release notes are available at https://v8.dev/blog/v8-release-78. Michaël Zasso [#30109](#30109). New EventEmitter APIs The new `EventEmitter.on` static method allows to async iterate over events. Matteo Collina [#27994](#27994). ___ It is now possible to monitor `'error'` events on an `EventEmitter` without consuming the emitted error by installing a listener using the symbol `EventEmitter.errorMonitor`. Gerhard Stoebich [#30932](#30932). ___ Using `async` functions with event handlers is problematic, because it can lead to an unhandled rejection in case of a thrown exception. The experimental `captureRejections` option in the `EventEmitter` constructor or the global setting change this behavior, installing a `.then(undefined, handler)` handler on the `Promise`. This handler routes the exception asynchronously to the `Symbol.for('nodejs.rejection')` method if there is one, or to the `'error'` event handler if there is none. Setting `EventEmitter.captureRejections = true` will change the default for all new instances of `EventEmitter`. This is an experimental feature. Matteo Collina [#27867](#27867). Performance Hooks are no longer experimental The `perf_hooks` module is now considered a stable API. legendecas [#31101](#31101). Introduction of experimental WebAssembly System Interface (WASI) support A new core module, `wasi`, is introduced to provide an implementation of the [WebAssembly System Interface](https://wasi.dev/) specification. WASI gives sandboxed WebAssembly applications access to the underlying operating system via a collection of POSIX-like functions. This is an experimental feature. Colin Ihrig [#30258](#30258). PR-URL: #31691

nodejs/node#30025

* chore: bump node in DEPS to v12.16.0 * Fixup asar support setup patch nodejs/node#30862 * Fixup InternalCallbackScope patch nodejs/node#30236 * Fixup GN buildfiles patch nodejs/node#30755 * Fixup low-level hooks patch nodejs/node#30466 * Fixup globals require patch nodejs/node#31643 * Fixup process stream patch nodejs/node#30862 * Fixup js2c modification patch nodejs/node#30755 * Fixup internal fs override patch nodejs/node#30610 * Fixup context-aware warn patch nodejs/node#30336 * Fixup Node.js with ltcg config nodejs/node#29388 * Fixup oaepLabel patch nodejs/node#30917 * Remove redundant ESM test patch nodejs/node#30997 * Remove redundant cli flag patch nodejs/node#30466 * Update filenames.json * Remove macro generation in GN build files nodejs/node#30755 * Fix some compilation errors upstream * Add uvwasi to deps nodejs/node#30258 * Fix BoringSSL incompatibilities * Fixup linked module patch nodejs/node#30274 * Add missing sources to GN uv build libuv/libuv#2347 * Patch some uvwasi incompatibilities * chore: bump Node.js to v12.6.1 * Remove mark_arraybuffer_as_untransferable.patch nodejs/node#30549 * Fix uvwasi build failure on win * Fixup --perf-prof cli option error * Fixup early cjs module loading * fix: initialize diagnostics properly nodejs/node#30025 * Disable new esm syntax specs nodejs/node#30219 * Fixup v8 weakref hook spec nodejs/node#29874 * Fix async context timer issue * Disable monkey-patch-main spec It relies on nodejs/node#29777, and we don't override prepareStackTrace. * Disable new tls specs nodejs/node#23188 We don't support much of TLS owing to schisms between BoringSSL and OpenSSL. Co-authored-by: Shelley Vohr <[email protected]>

cli: add --trace-uncaught flag

ce0bc30

Add a flag that makes Node.js print the stack trace at the time of *throwing* uncaught exceptions, rather than at the creation of the `Error` object, if there is any. This is disabled by default because it affects GC behavior.

nodejs-github-bot added the c++ Issues and PRs that require attention from people who are familiar with C++. label Oct 18, 2019

addaleax added cli Issues and PRs related to the Node.js command line interface. errors Issues and PRs related to JavaScript errors originated in Node.js core. semver-minor PRs that contain new features and should be released in the next minor version. labels Oct 18, 2019

fixup! cli: add --trace-uncaught flag

6a577ce

jasnell approved these changes Oct 18, 2019

View reviewed changes

richardlau approved these changes Oct 18, 2019

View reviewed changes

BridgeAR approved these changes Oct 18, 2019

View reviewed changes

gireeshpunathil approved these changes Oct 19, 2019

View reviewed changes

addaleax added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Oct 21, 2019

danbev closed this Oct 22, 2019

targos mentioned this pull request Nov 5, 2019

v13.1.0 release proposal #30262

Merged

targos mentioned this pull request Jan 15, 2020

v12.15.0 release proposal #31368

Closed

MylesBorins mentioned this pull request Feb 8, 2020

v12.16.0 proposal #31691

Merged

codebytere added a commit to electron/electron that referenced this pull request Feb 21, 2020

fix: initialize diagnostics properly

1ef34a3

nodejs/node#30025

codebytere added a commit to electron/electron that referenced this pull request Feb 21, 2020

fix: initialize diagnostics properly

b0ca0cf

nodejs/node#30025

codebytere added a commit to electron/electron that referenced this pull request Feb 21, 2020

fix: initialize diagnostics properly

60e8810

nodejs/node#30025

codebytere added a commit to electron/electron that referenced this pull request Feb 24, 2020

fix: initialize diagnostics properly

42be329

nodejs/node#30025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

cli: add --trace-uncaught flag #30025

cli: add --trace-uncaught flag #30025

addaleax commented Oct 18, 2019

nodejs-github-bot commented Oct 18, 2019

gireeshpunathil commented Oct 18, 2019

addaleax commented Oct 18, 2019

gireeshpunathil commented Oct 19, 2019

addaleax commented Oct 19, 2019 •

edited

Loading

nodejs-github-bot commented Oct 21, 2019

danbev commented Oct 22, 2019

cli: add --trace-uncaught flag #30025

cli: add --trace-uncaught flag #30025

Conversation

addaleax commented Oct 18, 2019

Checklist

nodejs-github-bot commented Oct 18, 2019

gireeshpunathil commented Oct 18, 2019

addaleax commented Oct 18, 2019

gireeshpunathil commented Oct 19, 2019

addaleax commented Oct 19, 2019 • edited Loading

nodejs-github-bot commented Oct 21, 2019

danbev commented Oct 22, 2019

addaleax commented Oct 19, 2019 •

edited

Loading