[v10.x] net: treat ENOTCONN at shutdown as success #29968
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
While it is not entirely clear why this condition is being triggered, it does resolve a reported bug. Fixes: nodejs#26315 PR-URL: nodejs#29912 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
This was referenced Oct 14, 2019
Merged
|
CI: https://ci.nodejs.org/job/node-test-pull-request/26012/ ✅ |
devnexen
approved these changes
Oct 14, 2019
BethGriggs
approved these changes
Oct 15, 2019
BethGriggs
pushed a commit
that referenced
this pull request
Oct 16, 2019
While it is not entirely clear why this condition is being triggered, it does resolve a reported bug. Fixes: #26315 Backport-PR-URL: #29968 PR-URL: #29912 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
|
Landed on |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Only trivial conflicts (
process.binding()vsinternalBinding()).While it is not entirely clear why this condition is being
triggered, it does resolve a reported bug.
Fixes: #26315
PR-URL: #29912
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes