stream: eos more accurate writable and readable detection #29409
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The value of stream.readable and stream.writable should not be used to detect whether a stream is Writable or Readable. Refs: nodejs#29395
ronag
force-pushed
the
eos-writable-readable
branch
from
afe332c to
5b6e33a
Compare
|
Might it be useful to publicly expose these? |
|
@Fishrock123: Something like? const { isReadable, isWritable } = require('stream'); |
|
@ronag Yes, although I'd like to hear others chime in on the stability of such functions. |
|
@nodejs/streams |
jasnell
approved these changes
Sep 11, 2019
|
@Trott: This looks ready? |
Trott
pushed a commit
that referenced
this pull request
Sep 22, 2019
The value of stream.readable and stream.writable should not be used to detect whether a stream is Writable or Readable. Refs: #29395 PR-URL: #29409 Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: James M Snell <[email protected]>
|
Landed in 8709a40 |
|
Should this be backported to |
|
@targos: Never done it before but I will take a look. Will try to have something ready this week. |
|
I'd very much like to have this merged and included in such a backport, #29664. |
|
quick ping re: backport |
|
@MylesBorins Coincidentally I started looking at backporting this one on Friday - PR ready now |
sxa
pushed a commit
to sxa/node
that referenced
this pull request
Jan 13, 2020
The value of stream.readable and stream.writable should not be used to detect whether a stream is Writable or Readable. PR-URL: nodejs#29409 Backport-PR-URL: nodejs#31345
targos
pushed a commit
that referenced
this pull request
Jan 14, 2020
The value of stream.readable and stream.writable should not be used to detect whether a stream is Writable or Readable. Refs: #29395 PR-URL: #29409 Backport-PR-URL: #31345 Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: James M Snell <[email protected]>
BethGriggs
pushed a commit
that referenced
this pull request
Feb 6, 2020
The value of stream.readable and stream.writable should not be used to detect whether a stream is Writable or Readable. Refs: #29395 PR-URL: #29409 Backport-PR-URL: #31345 Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: James M Snell <[email protected]>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The value of stream.readable and stream.writable should not
be used to detect whether a stream is Writable or Readable.
Refs: #29395
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes