doc: make execFileSync in line with execFile #2940
Conversation
make execFileSync API docs in line with execFile API docs
|
LGTM |
mscdex
added
the
child_process
|
@lfortin while you're at it, could you move the whole |
lfortin
force-pushed
the
doc-execfilesync
branch
from
103d869 to
66a6f76
Compare
|
@silverwind done. |
|
@lfortin The diff looks a bit unwieldy, this is just a cut-paste job, right? |
|
@silverwind yes it is. I confirm that the text is well formatted. |
|
Alright, LGTM. |
| @@ -735,10 +735,15 @@ If the process times out, or has a non-zero exit code, this method ***will*** | |||
| throw. The `Error` object will contain the entire result from | |||
| [`child_process.spawnSync`](#child_process_child_process_spawnsync_command_args_options) | |||
|
|
|||
| [EventEmitter]: events.html#events_class_events_eventemitter | |||
| [net.Server]: net.html#net_class_net_server | |||
| [net.Socket]: net.html#net_class_net_socket | |||
There was a problem hiding this comment.
I'm not sure these should have moved. Isn't there a convention to put the link definitions at the end of the file ?
There was a problem hiding this comment.
Oh, good catch. These should indeed remain an the end of the file, @lfortin.
|
@targos I see, my bad. I will re-issue a new commit with the link definitions at the end of the file. /cc @silverwind |
lfortin
force-pushed
the
doc-execfilesync
branch
from
6b69b3d to
66a6f76
Compare
|
@targos @silverwind done. |
| @@ -766,6 +767,7 @@ If the process times out, or has a non-zero exit code, this method ***will*** | |||
| throw. The `Error` object will contain the entire result from | |||
| [`child_process.spawnSync`](#child_process_child_process_spawnsync_command_args_options) | |||
|
|
|||
|
|
|||
There was a problem hiding this comment.
I'm sorry but this looks like an unnecessary newline.
lfortin
force-pushed
the
doc-execfilesync
branch
from
e05bb82 to
66a6f76
Compare
rearrange execSync, execFileSync API docs to be in line with exec, execFile API docs
|
@silverwind unnecessary new line removed. |
|
LGTM |
1 similar comment
|
LGTM |
PR-URL: #2940 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Roman Reiss <[email protected]>
Changed the ordering so it is in line with the async methods. PR-URL: #2940 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Roman Reiss <[email protected]>
PR-URL: #2940 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Roman Reiss <[email protected]>
Changed the ordering so it is in line with the async methods. PR-URL: #2940 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Roman Reiss <[email protected]>
Make execFileSync API docs in line with execFile API docs.