worker: make transfer list behave like web MessagePort #29319
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
the
c++
Allow generic iterables as transfer list arguments, as well as an options object with a `transfer` option, for web compatibility. Refs: nodejs#28033 (comment)
addaleax
force-pushed
the
worker-transferlist-iterable
branch
from
992bca1 to
440f2b2
Compare
jasnell
approved these changes
Aug 26, 2019
danbev
added
the
author ready
danbev
pushed a commit
that referenced
this pull request
Sep 6, 2019
Allow generic iterables as transfer list arguments, as well as an options object with a `transfer` option, for web compatibility. PR-URL: #29319 Refs: #28033 (comment) Reviewed-By: James M Snell <[email protected]>
|
Landed in 72650bc. |
targos
pushed a commit
that referenced
this pull request
Sep 20, 2019
Allow generic iterables as transfer list arguments, as well as an options object with a `transfer` option, for web compatibility. PR-URL: #29319 Refs: #28033 (comment) Reviewed-By: James M Snell <[email protected]>
Merged
This was referenced Sep 25, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(The diff is a bit easier to view with whitespace diffing disabled.)
Allow generic iterables as transfer list arguments, as well
as an options object with a
transferoption, for web compatibility.Refs: #28033 (comment)
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes