-
Notifications
You must be signed in to change notification settings - Fork 30k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
http: replace superfluous property with getter/setter #29015
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ronag
changed the title
http: replace duplicate property with getter/setter
http: replace superfluous property with getter/setter
Aug 6, 2019
addaleax
approved these changes
Aug 6, 2019
AFAIK getters/setters like this incur noticeable overhead, so perhaps we should be adjusting the documentation to more strongly recommend |
Also if we're making this change we should also replace all usage of |
ronag
force-pushed
the
http-connection
branch
2 times, most recently
from
August 6, 2019 12:51
551d5ec
to
9fe52d4
Compare
@mscdex better? |
ronag
force-pushed
the
http-connection
branch
7 times, most recently
from
August 6, 2019 13:56
c16f5f6
to
80a07da
Compare
trivikr
reviewed
Aug 6, 2019
jasnell
approved these changes
Aug 7, 2019
jasnell
added
deprecations
Issues and PRs related to deprecations.
semver-major
PRs that contain breaking changes and should be released in the next major version.
labels
Aug 7, 2019
trivikr
approved these changes
Aug 7, 2019
lpinca
approved these changes
Aug 9, 2019
@Trott: this seems ready |
Trott
approved these changes
Aug 17, 2019
Landed in 0daec61 |
This was referenced Jan 20, 2021
This was referenced Sep 5, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
deprecations
Issues and PRs related to deprecations.
http
Issues or PRs related to the http subsystem.
semver-major
PRs that contain breaking changes and should be released in the next major version.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Slightly reduces memory overhead by replacing superfluous property with getter/setter.
Checklist
make -j4 test
(UNIX), orvcbuild test
(Windows) passes