Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[x] fs: don't emit open after destroy #28765

Closed
wants to merge 1 commit into from
Closed

[x] fs: don't emit open after destroy #28765

wants to merge 1 commit into from

Conversation

ronag
Copy link
Member

@ronag ronag commented Jul 19, 2019 •
edited
Loading

Not perfect but still better than it was.

Refs: #23133

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added the fs Issues and PRs related to the fs subsystem / file system. label Jul 19, 2019
@ronag ronag force-pushed the fix-fs-open-destroy branch from d3fdc9b to ff9b6fc Compare July 19, 2019 14:21
mscdex
mscdex reviewed Jul 19, 2019
View reviewed changes
lib/internal/fs/streams.js Outdated Show resolved Hide resolved
@ronag ronag force-pushed the fix-fs-open-destroy branch 2 times, most recently from f404a6a to e7a8e22 Compare July 19, 2019 17:51
@ronag
Copy link
Member Author

ronag commented Jul 19, 2019

This might need a sem-ver major due to the updated test.

@ronag ronag force-pushed the fix-fs-open-destroy branch from e7a8e22 to 281772e Compare July 19, 2019 17:52
@Trott
Copy link
Member

Trott commented Jul 22, 2019

@nodejs/fs

@jasnell jasnell added the semver-major PRs that contain breaking changes and should be released in the next major version. label Jul 29, 2019
@trivikr trivikr requested a review from mscdex July 29, 2019 20:07
@ronag
Copy link
Member Author

ronag commented Aug 2, 2019

@Trott author ready?

@Trott
Copy link
Member

Trott commented Aug 2, 2019

@Trott author ready?

It's semver-major and all (or at least many) semver-major PRs are blocked on standard-things/esm#821. 😞

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/24824/

This was referenced Aug 6, 2019
Closed
Closed
@ronag
Copy link
Member Author

ronag commented Aug 25, 2019 •
edited
Loading

Alternative solution which is further into the future nxtedition#2.

@ronag
Copy link
Member Author

ronag commented Aug 28, 2019 •
edited
Loading

closing for now, there are other PR's that solves this better, but with bigger changes.

@ronag ronag closed this Aug 28, 2019
@ronag ronag changed the title fs: don't emit open after destroy [x] fs: don't emit open after destroy Aug 28, 2019
@fsouza fsouza mentioned this pull request Nov 19, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasnell jasnell jasnell approved these changes

@mscdex mscdex Awaiting requested review from mscdex

Assignees
No one assigned
Labels
fs Issues and PRs related to the fs subsystem / file system. semver-major PRs that contain breaking changes and should be released in the next major version.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@ronag @Trott @nodejs-github-bot @mscdex @jasnell