-
Notifications
You must be signed in to change notification settings - Fork 30k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
doc: replace version with REPLACEME #28431
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Node 12.4.0 has already been released. Replace the version with REPLACEME so that the proper version gets inserted at release time. Refs: nodejs#28007
nodejs-github-bot
added
doc
Issues and PRs related to the documentations.
stream
Issues and PRs related to the stream subsystem.
labels
Jun 26, 2019
addaleax
approved these changes
Jun 26, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 to fast-track
richardlau
approved these changes
Jun 26, 2019
Lite CI: https://ci.nodejs.org/job/node-test-pull-request-lite-pipeline/3718/ EDIT: CI was green. |
richardlau
added
author ready
PRs that have at least one approval, no pending requests for changes, and a CI started.
fast-track
PRs that do not need to wait for 48 hours to land.
labels
Jun 26, 2019
BridgeAR
approved these changes
Jun 26, 2019
Trott
approved these changes
Jun 26, 2019
trivikr
approved these changes
Jun 26, 2019
Landed in 5b4a0cb. |
danbev
pushed a commit
that referenced
this pull request
Jun 26, 2019
Node 12.4.0 has already been released. Replace the version with REPLACEME so that the proper version gets inserted at release time. PR-URL: #28431 Refs: #28007 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]>
targos
pushed a commit
that referenced
this pull request
Jul 2, 2019
Node 12.4.0 has already been released. Replace the version with REPLACEME so that the proper version gets inserted at release time. PR-URL: #28431 Refs: #28007 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]>
This was referenced Jul 3, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
author ready
PRs that have at least one approval, no pending requests for changes, and a CI started.
doc
Issues and PRs related to the documentations.
fast-track
PRs that do not need to wait for 48 hours to land.
stream
Issues and PRs related to the stream subsystem.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Node 12.4.0 has already been released. Replace the version with REPLACEME so that the proper version gets inserted at release time.
Refs: #28007
Checklist
make -j4 test
(UNIX), orvcbuild test
(Windows) passes