Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: clarify response.finished #28411

Closed
wants to merge 1 commit into from
Closed

docs: clarify response.finished #28411

wants to merge 1 commit into from

Conversation

ronag
Copy link
Member

@ronag ronag commented Jun 24, 2019 •
edited
Loading

This fixes some regular confusion in regards to the response.finished property and makes it more consistent with the description for request.finished.

Refs: jshttp/on-finished#30

Checklist

@nodejs-github-bot nodejs-github-bot added doc Issues and PRs related to the documentations. http Issues or PRs related to the http subsystem. labels Jun 24, 2019
This was referenced Jun 24, 2019
Closed
Open
vsemozhetbyt
vsemozhetbyt reviewed Jun 25, 2019
View reviewed changes
doc/api/http.md Outdated Show resolved Hide resolved
@ronag ronag force-pushed the fix-finished-docs branch from 4797264 to 6ecd5a8 Compare June 25, 2019 06:29
@ronag ronag force-pushed the fix-finished-docs branch from 6ecd5a8 to 0999d49 Compare June 26, 2019 19:38
@Trott
Copy link
Member

Trott commented Jun 27, 2019

Lite CI: https://ci.nodejs.org/job/node-test-pull-request-lite-pipeline/3722/

@Trott Trott added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Jun 27, 2019
@Trott
Copy link
Member

Trott commented Jun 27, 2019

Landed in 63a0f4c

Trott pushed a commit to Trott/io.js that referenced this pull request Jun 27, 2019
@ronag @Trott
doc: clarify response.finished
63a0f4c 
PR-URL: nodejs#28411
Refs: jshttp/on-finished#30
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
@Trott Trott closed this Jun 27, 2019
targos pushed a commit that referenced this pull request Jul 2, 2019
@ronag @targos
doc: clarify response.finished
3c047b3 
PR-URL: #28411
Refs: jshttp/on-finished#30
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
@targos targos mentioned this pull request Jul 2, 2019
Merged
This was referenced Jul 3, 2019
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vsemozhetbyt vsemozhetbyt vsemozhetbyt left review comments

@trivikr trivikr trivikr approved these changes

@lpinca lpinca lpinca approved these changes

@Trott Trott Trott approved these changes

@jasnell jasnell jasnell approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. doc Issues and PRs related to the documentations. http Issues or PRs related to the http subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@ronag @Trott @jasnell @lpinca @vsemozhetbyt @trivikr @nodejs-github-bot