Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: refactor test-buffer-failed-alloc-type #28349

Closed
wants to merge 1 commit into from
Closed

test: refactor test-buffer-failed-alloc-type #28349

wants to merge 1 commit into from

Conversation

RamirezAlex
Copy link
Contributor

Switch the argument order for the assertion to be in the correct order (actual, expected)

  • make -j4 test (UNIX)
  • [x ] commit message follows [commit guidelines]

@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label Jun 21, 2019
@addaleax addaleax added the code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. label Jun 21, 2019
Trott
Trott approved these changes Jun 21, 2019
View reviewed changes
Copy link
Member

@Trott Trott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Commit message could be improved a little bit by specifying what the change is rather than just refactor. Maybe something like this?: test: fix assertion argument order in test-buffer-failed-alloc-type

@RamirezAlex RamirezAlex force-pushed the refactor-test-buffer branch from a376245 to 7f4120b Compare June 21, 2019 21:41
@Trott
Copy link
Member

Trott commented Jun 22, 2019

Lite CI: https://ci.nodejs.org/job/node-test-pull-request-lite-pipeline/3702/

@Trott Trott added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Jun 22, 2019
@Trott
Copy link
Member

Trott commented Jun 24, 2019

Landed in ad8456b

@Trott Trott closed this Jun 24, 2019
Trott pushed a commit to Trott/io.js that referenced this pull request Jun 24, 2019
@RamirezAlex @Trott
test: fix assertion argument order in test-buffer-failed-alloc-type
ad8456b 
PR-URL: nodejs#28349
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
Reviewed-By: James M Snell <[email protected]>
targos pushed a commit that referenced this pull request Jul 2, 2019
@RamirezAlex @targos
test: fix assertion argument order in test-buffer-failed-alloc-type
758a003 
PR-URL: #28349
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@targos targos mentioned this pull request Jul 2, 2019
Merged
This was referenced Jul 3, 2019
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@trivikr trivikr trivikr approved these changes

@BridgeAR BridgeAR BridgeAR approved these changes

@gireeshpunathil gireeshpunathil gireeshpunathil approved these changes

@cjihrig cjihrig cjihrig approved these changes

@targos targos targos approved these changes

@addaleax addaleax addaleax approved these changes

@Trott Trott Trott approved these changes

@jasnell jasnell jasnell approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
10 participants
@RamirezAlex @Trott @jasnell @addaleax @targos @cjihrig @gireeshpunathil @BridgeAR @trivikr @nodejs-github-bot