Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: remove test-ttywrap.writestream #28316

Merged
merged 1 commit into from
Jun 22, 2019

Conversation

Trott
Copy link
Member

@Trott Trott commented Jun 20, 2019

The test is never run in CI and may have never worked.

Refs: #28304

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added async_hooks Issues and PRs related to the async hooks subsystem. test Issues and PRs related to the tests. labels Jun 20, 2019
@nodejs-github-bot
Copy link
Collaborator

@Trott Trott added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Jun 20, 2019
@addaleax
Copy link
Member

This is removing a different test than the one that is referenced in the issue … is that intentional?

@Trott
Copy link
Member Author

Trott commented Jun 20, 2019

This is removing a different test than the one that is referenced in the issue … is that intentional?

Argh! No, that was an error. Fixing....

@Trott Trott force-pushed the rm-test-that-never-runs branch from 113bb30 to 3b97f5d Compare June 20, 2019 21:02
@Trott Trott changed the title test: remove test-graph.signal test: remove test-ttywrap.writestream Jun 20, 2019
@Trott
Copy link
Member Author

Trott commented Jun 20, 2019

Fixed. Re-running CI....

@nodejs-github-bot
Copy link
Collaborator

@nodejs-github-bot
Copy link
Collaborator

@nodejs-github-bot
Copy link
Collaborator

@nodejs-github-bot
Copy link
Collaborator

The test is never run in CI and may have never worked.

Refs: nodejs#28304
PR-URL: nodejs#28316
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@Trott Trott force-pushed the rm-test-that-never-runs branch from 3b97f5d to 6e66313 Compare June 22, 2019 13:02
@Trott
Copy link
Member Author

Trott commented Jun 22, 2019

Landed in 6e66313

@Trott Trott merged commit 6e66313 into nodejs:master Jun 22, 2019
targos pushed a commit that referenced this pull request Jul 2, 2019
The test is never run in CI and may have never worked.

Refs: #28304
PR-URL: #28316
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@targos targos mentioned this pull request Jul 2, 2019
@Trott Trott deleted the rm-test-that-never-runs branch January 13, 2022 22:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
async_hooks Issues and PRs related to the async hooks subsystem. author ready PRs that have at least one approval, no pending requests for changes, and a CI started. test Issues and PRs related to the tests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants