Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: revise assert legacy mode text #28315

Merged
merged 1 commit into from
Jun 22, 2019
Merged

doc: revise assert legacy mode text #28315

merged 1 commit into from
Jun 22, 2019

Conversation

Trott
Copy link
Member

@Trott Trott commented Jun 20, 2019

Revise the text for the assert module's legacy mode to make it simpler
and more scannable.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added assert Issues and PRs related to the assert subsystem. doc Issues and PRs related to the documentations. labels Jun 20, 2019
@Trott Trott added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Jun 20, 2019
@Trott
Copy link
Member Author

Trott commented Jun 20, 2019

Lite CI: https://ci.nodejs.org/job/node-test-pull-request-lite-pipeline/3697/

@Trott
doc: revise assert legacy mode text
ad2036f 
Revise the text for the `assert` module's legacy mode to make it simpler
and more scannable.

PR-URL: nodejs#28315
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
@Trott
Copy link
Member Author

Trott commented Jun 22, 2019

Landed in ad2036f

@Trott Trott merged commit ad2036f into nodejs:master Jun 22, 2019
targos pushed a commit that referenced this pull request Jul 2, 2019
@Trott @targos
doc: revise assert legacy mode text
51742b8 
Revise the text for the `assert` module's legacy mode to make it simpler
and more scannable.

PR-URL: #28315
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
@targos targos mentioned this pull request Jul 2, 2019
Merged
This was referenced Jul 3, 2019
Closed
Closed
Closed
@Trott Trott deleted the legacy branch January 13, 2022 22:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@trivikr trivikr trivikr approved these changes

@benjamingr benjamingr benjamingr approved these changes

Assignees
No one assigned
Labels
assert Issues and PRs related to the assert subsystem. author ready PRs that have at least one approval, no pending requests for changes, and a CI started. doc Issues and PRs related to the documentations.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Trott @benjamingr @trivikr @nodejs-github-bot