Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

meta: update LICENSE #28260

Merged
merged 1 commit into from
Jun 19, 2019
Merged

meta: update LICENSE #28260

merged 1 commit into from
Jun 19, 2019

Conversation

Trott
Copy link
Member

@Trott Trott commented Jun 17, 2019

A few dependencies have been updated or added without running
license_builder.sh. This updates based on current master branch.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@nodejs-github-bot

This comment has been minimized.

@nodejs-github-bot nodejs-github-bot added the meta Issues and PRs related to the general management of the project. label Jun 17, 2019
@Trott
Copy link
Member Author

Trott commented Jun 17, 2019

@Trott Trott added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Jun 17, 2019
Copy link
Member

@mhdawson mhdawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@MylesBorins MylesBorins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

A few dependencies have been updated or added without running
license_builder.sh. This updates based on current master branch.

PR-URL: nodejs#28260
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Yongsheng Zhang <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
Reviewed-By: Myles Borins <[email protected]>
Reviewed-By: Franziska Hinkelmann <[email protected]>
@Trott Trott force-pushed the license-updates-yo branch from e93f68a to e585846 Compare June 19, 2019 04:17
@Trott
Copy link
Member Author

Trott commented Jun 19, 2019

Landed in e585846

@Trott Trott merged commit e585846 into nodejs:master Jun 19, 2019
targos pushed a commit that referenced this pull request Jul 2, 2019
A few dependencies have been updated or added without running
license_builder.sh. This updates based on current master branch.

PR-URL: #28260
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Yongsheng Zhang <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
Reviewed-By: Myles Borins <[email protected]>
Reviewed-By: Franziska Hinkelmann <[email protected]>
@targos targos mentioned this pull request Jul 2, 2019
@Trott Trott deleted the license-updates-yo branch January 13, 2022 22:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. meta Issues and PRs related to the general management of the project.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants