Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: tidy AssertionError text #28255

Merged
merged 1 commit into from
Jun 18, 2019
Merged

doc: tidy AssertionError text #28255

merged 1 commit into from
Jun 18, 2019

Conversation

Trott
Copy link
Member

@Trott Trott commented Jun 16, 2019

Several minor improvements to text. Remove some repetition.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines

@nodejs-github-bot

This comment has been minimized.

Sign in to view
@nodejs-github-bot nodejs-github-bot added assert Issues and PRs related to the assert subsystem. doc Issues and PRs related to the documentations. labels Jun 16, 2019
@Trott
Copy link
Member Author

Trott commented Jun 16, 2019

Lite CI: https://ci.nodejs.org/job/node-test-pull-request-lite-pipeline/3684/

@Trott Trott added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Jun 17, 2019
@Trott
doc: tidy AssertionError text
17a5eba 
Several minor improvements to text. Remove some repetition.

PR-URL: nodejs#28255
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
@Trott Trott force-pushed the assertion-error branch from 887207f to 17a5eba Compare June 18, 2019 23:19
@Trott
Copy link
Member Author

Trott commented Jun 18, 2019

Landed in 17a5eba

@Trott Trott merged commit 17a5eba into nodejs:master Jun 18, 2019
targos pushed a commit that referenced this pull request Jul 2, 2019
@Trott @targos
doc: tidy AssertionError text
168c127 
Several minor improvements to text. Remove some repetition.

PR-URL: #28255
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
@targos targos mentioned this pull request Jul 2, 2019
Merged
This was referenced Jul 3, 2019
Closed
Closed
Closed
@Trott Trott deleted the assertion-error branch January 13, 2022 22:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@trivikr trivikr trivikr approved these changes

@BridgeAR BridgeAR BridgeAR approved these changes

@jasnell jasnell jasnell approved these changes

Assignees
No one assigned
Labels
assert Issues and PRs related to the assert subsystem. author ready PRs that have at least one approval, no pending requests for changes, and a CI started. doc Issues and PRs related to the documentations.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Trott @nodejs-github-bot @jasnell @BridgeAR @trivikr