Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

src: add error codes to errors thrown in node_i18n.cc #28221

Closed
wants to merge 1 commit into from
Closed

src: add error codes to errors thrown in node_i18n.cc #28221

wants to merge 1 commit into from

Conversation

yanivfriedensohn
Copy link
Contributor

This PR follows #20121 and adds error codes to errors thrown in node_i18n.cc.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. i18n-api Issues and PRs related to the i18n implementation. labels Jun 14, 2019
@yanivfriedensohn yanivfriedensohn force-pushed the add-error-codes-to-errors-2 branch from e375489 to 2528956 Compare June 14, 2019 12:05
@yanivfriedensohn yanivfriedensohn changed the title src: assign error codes to errors thrown in node_i18n.cc src: add error codes to errors thrown in node_i18n.cc Jun 14, 2019
@yanivfriedensohn yanivfriedensohn force-pushed the add-error-codes-to-errors-2 branch 2 times, most recently from 3d7fec8 to 400486b Compare June 14, 2019 14:56
@yanivfriedensohn yanivfriedensohn force-pushed the add-error-codes-to-errors-2 branch from 400486b to 3ec5081 Compare June 15, 2019 06:56
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/23927/

@yanivfriedensohn
Copy link
Contributor Author

@jasnell @Trott the failed tests doesn't seem to be related to the changes of this PR. Can we rerun the CI process?

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/24032/

@Trott Trott added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Jun 21, 2019
@Trott
Copy link
Member

Trott commented Jun 21, 2019 •
edited
Loading

@jasnell @Trott the failed tests doesn't seem to be related to the changes of this PR. Can we rerun the CI process?

I just started a "resume build" which will re-run just Windows at the same commit/rebase it did 4 days ago. That failure (test-statwatcher) was a very problematic unreliable issue that has since been fixed. If it fails again on the resume-build, we may just want to do a full re-run so that we rebase and get the fix. The problem with doing that right now is that we're having AIX problems in CI and AIX will undoubtedly fail for unrelated reasons. I would expect that AIX issue to get fixed in a few hours (once it's not the middle of the night for the relevant folks with expertise). This is probably too much detail, but the upshot is: If the re-run doesn't pass, feel free to ping again, don't hesitate.

I've added an author ready flag to this which is basically something that a few of us search for every so often to find PRs that are ready to land, so this shouldn't get missed/ignored, but ping anyway. 😀

@Trott
Copy link
Member

Trott commented Jun 21, 2019

Landed in e6edd66

@Trott Trott closed this Jun 21, 2019
Trott pushed a commit to Trott/io.js that referenced this pull request Jun 21, 2019
@yanivfriedensohn @Trott
src: add error codes to errors thrown in node_i18n.cc
e6edd66 
PR-URL: nodejs#28221
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
@yanivfriedensohn yanivfriedensohn deleted the add-error-codes-to-errors-2 branch June 21, 2019 10:29
targos pushed a commit that referenced this pull request Jul 2, 2019
@yanivfriedensohn @targos
src: add error codes to errors thrown in node_i18n.cc
0044fd2 
PR-URL: #28221
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
@targos targos mentioned this pull request Jul 2, 2019
Merged
This was referenced Jul 3, 2019
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Trott Trott Trott approved these changes

@jasnell jasnell jasnell approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. c++ Issues and PRs that require attention from people who are familiar with C++. i18n-api Issues and PRs related to the i18n implementation.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@yanivfriedensohn @nodejs-github-bot @Trott @jasnell