Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps: use nghttp2's config.h on all platforms #27283

Closed
wants to merge 1 commit into from

Conversation

sam-github
Copy link
Contributor

Fix warnings about use of htonl(), etc. by including config.h for all
platforms, defining HAVE_ARPA_INET_H on non-Windows, and therefore
including <arpa/inet.h>, which defines the host to network byte order
conversion functions.

--

This works on Linux, I'll see what ci says about the other platforms.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

@nodejs-github-bot
Copy link
Collaborator

@nodejs-github-bot nodejs-github-bot added build Issues and PRs related to build files or the CI. dont-land-on-v6.x http2 Issues or PRs related to the http2 subsystem. labels Apr 17, 2019
@nodejs-github-bot
Copy link
Collaborator

deps/nghttp2/nghttp2.gyp Outdated Show resolved Hide resolved
@nodejs-github-bot
Copy link
Collaborator

@richardlau
Copy link
Member

Travis failed with:
https://travis-ci.com/nodejs/node/jobs/193769803#L264-L285

=== release test-crypto-sign-verify ===
Path: parallel/test-crypto-sign-verify
--- stderr ---
assert.js:523
      throw err;
      ^
AssertionError [ERR_ASSERTION]: Expected values to be strictly deep-equal:
+ actual - expected
  Comparison {
+   message: 'error:0908F070:PEM routines:get_header_and_data:short header'
-   message: 'bye, bye, library'
  }
    at Object.<anonymous> (/home/travis/build/nodejs/node/test/parallel/test-crypto-sign-verify.js:42:10)
    at Module._compile (internal/modules/cjs/loader.js:766:30)
    at Object.Module._extensions..js (internal/modules/cjs/loader.js:777:10)
    at Module.load (internal/modules/cjs/loader.js:635:32)
    at Function.Module._load (internal/modules/cjs/loader.js:562:12)
    at Function.Module.runMain (internal/modules/cjs/loader.js:833:10)
    at internal/main/run_main_module.js:17:11
Command: out/Release/node /home/travis/build/nodejs/node/test/parallel/test-crypto-sign-verify.js

Unrelated?

Fix warnings about use of htonl(), etc. by including config.h for all
platforms, defining HAVE_ARPA_INET_H on non-Windows, and therefore
including <arpa/inet.h>, which defines the host to network byte order
conversion functions.
@sam-github sam-github force-pushed the use-nghttp2-config-h branch from b35242b to 454d6dd Compare April 18, 2019 16:44
@sam-github
Copy link
Contributor Author

Should not be related, I wrote that test in #27157, and it passed there, except travis's CI state isn't visible anymore.

I found some other recent travis jobs that include #27157, and they passed, like https://travis-ci.com/nodejs/node/builds/108825880

I rebased against master, and repushed.

@nodejs-github-bot
Copy link
Collaborator

@sam-github
Copy link
Contributor Author

Landed in 90cf2d5

@sam-github sam-github closed this Apr 22, 2019
@sam-github sam-github deleted the use-nghttp2-config-h branch April 22, 2019 19:08
sam-github added a commit that referenced this pull request Apr 22, 2019
Fix warnings about use of htonl(), etc. by including config.h for all
platforms, defining HAVE_ARPA_INET_H on non-Windows, and therefore
including <arpa/inet.h>, which defines the host to network byte order
conversion functions.

PR-URL: #27283
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Joyee Cheung <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Refael Ackermann <[email protected]>
codebytere added a commit to electron/electron that referenced this pull request Aug 25, 2022
codebytere added a commit to electron/electron that referenced this pull request Aug 25, 2022
codebytere added a commit to electron/electron that referenced this pull request Aug 29, 2022
codebytere added a commit to electron/electron that referenced this pull request Aug 29, 2022
trop bot pushed a commit to electron/electron that referenced this pull request Aug 29, 2022
trop bot pushed a commit to electron/electron that referenced this pull request Aug 29, 2022
codebytere added a commit to electron/electron that referenced this pull request Aug 29, 2022
jkleinsc pushed a commit to electron/electron that referenced this pull request Aug 29, 2022
codebytere added a commit to electron/electron that referenced this pull request Aug 30, 2022
khalwa pushed a commit to solarwindscloud/electron that referenced this pull request Feb 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build Issues and PRs related to build files or the CI. http2 Issues or PRs related to the http2 subsystem.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants