Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: mark some known flakes #27193

Merged
merged 1 commit into from
Apr 11, 2019
Merged

test: mark some known flakes #27193

merged 1 commit into from
Apr 11, 2019

Conversation

refack
Copy link
Contributor

@refack refack commented Apr 11, 2019 •
edited
Loading

Refs: #20750
Refs: #26610

@nodejs/testing PTAL

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

@nodejs-github-bot
Copy link
Collaborator

Lite-CI: https://ci.nodejs.org/job/node-test-pull-request-lite-pipeline/3233

@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label Apr 11, 2019
@refack refack added flaky-test Issues and PRs related to the tests with unstable failures on the CI. fast-track PRs that do not need to wait for 48 hours to land. labels Apr 11, 2019
@refack
Copy link
Contributor Author

refack commented Apr 11, 2019

I move this should be fast tracked, please 👍 here if you concur.

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/22377/

@refack
test: mark some known flakes
abe4183 
PR-URL: nodejs#27193
Refs: nodejs#20750
Refs: nodejs#26610
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
@refack refack force-pushed the mark-some-flakes branch from 4808bf1 to abe4183 Compare April 11, 2019 19:43
@refack
Copy link
Contributor Author

refack commented Apr 11, 2019

Fast tracking with 2 up-votes
image

@refack refack merged commit abe4183 into nodejs:master Apr 11, 2019
@refack refack deleted the mark-some-flakes branch April 11, 2019 19:45
This was referenced Apr 23, 2019
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@richardlau richardlau richardlau approved these changes

@Trott Trott Trott approved these changes

Assignees
No one assigned
Labels
fast-track PRs that do not need to wait for 48 hours to land. flaky-test Issues and PRs related to the tests with unstable failures on the CI. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@refack @nodejs-github-bot @Trott @richardlau