test: fix test-worker-memory.js for large cpu #s #27090
Conversation
This test consistently failed on a system with a large number of cores (~120). Cap the number of concurrent workers so we'll stay consistently within the "slack" allowed with respect to rss.
BridgeAR
added
the
author ready
|
As a side note: I had come across the same issue and attempted to address it in a similar manner, but did not proceed when I realized that there is another problem, that may be harder to solve: when too many workers run in truly parallel manner, the This fix looks reasonable; but if the issue recurs even with this, we should suspect the non-deterministic behavior of |
Co-Authored-By: mhdawson <[email protected]>
|
CI was good landing. |
|
See that comment was changed sinc last CI run. Lite CI to be safe: https://ci.nodejs.org/job/node-test-pull-request-lite-pipeline/3198/ |
|
Landed as f96a660 |
This test consistently failed on a system with a large number of cores (~120). Cap the number of concurrent workers so we'll stay consistently within the "slack" allowed with respect to rss. PR-URL: #27090 Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]>
This test consistently failed on a system with a
large number of cores (~120). Cap the number of
concurrent workers so we'll stay consistently within
the "slack" allowed with respect to rss.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes