url: remove usage of require('util') #26808
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jasnell
approved these changes
Mar 21, 2019
|
@nodejs/tsc ... just a quick note: we need to be clear on how these kinds of changes need to be handled semver-wise. This change, for instance, changes the monkey-patch-ability of |
|
I think we should generally consider this semver-patch. It is not part of the API contract of the URL module that the |
BridgeAR
approved these changes
Mar 22, 2019
BridgeAR
added
the
author ready
ZYSzys
approved these changes
Mar 22, 2019
|
Landed in 5b59b5f 🎉 |
ZYSzys
pushed a commit
that referenced
this pull request
Mar 24, 2019
PR-URL: #26808 Refs: #26546 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Yongsheng Zhang <[email protected]>
targos
pushed a commit
to targos/node
that referenced
this pull request
Mar 27, 2019
PR-URL: nodejs#26808 Refs: nodejs#26546 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Yongsheng Zhang <[email protected]>
targos
pushed a commit
that referenced
this pull request
Mar 27, 2019
PR-URL: #26808 Refs: #26546 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Yongsheng Zhang <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove the usage of public require('util').
Use require('internal/util/inspect').inspect instead of require('util').inspect.
Refs: #26546
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes