lib: remove usage of require('util') #26773
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove usage of public require('util') in
`internal/child_process`.
Refs: nodejs#26546
nodejs-github-bot
added
the
child_process
ZYSzys
approved these changes
Mar 19, 2019
targos
approved these changes
Mar 19, 2019
|
@dnlup No, it's fine :) . The machine was disconnected while it was running the tests. |
ZYSzys
added
the
author ready
|
Landed in 1500e5d 🎉 Thank you for your contribution ! |
ZYSzys
pushed a commit
that referenced
this pull request
Mar 21, 2019
Remove usage of public require('util') in
`internal/child_process`.
Refs: #26546
PR-URL: #26773
Reviewed-By: Yongsheng Zhang <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
targos
pushed a commit
to targos/node
that referenced
this pull request
Mar 27, 2019
Remove usage of public require('util') in
`internal/child_process`.
Refs: nodejs#26546
PR-URL: nodejs#26773
Reviewed-By: Yongsheng Zhang <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
targos
pushed a commit
that referenced
this pull request
Mar 27, 2019
Remove usage of public require('util') in
`internal/child_process`.
Refs: #26546
PR-URL: #26773
Reviewed-By: Yongsheng Zhang <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove usage of public require('util') in
internal/child_process.Refs: #26546
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes