perf_hooks: reset prev_ before starting ELD timer #26693
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
reset `ELDHistogram.prev_` before staring timer to ensure that start timer doesn't leak across `disable()` `enable()` calls.
nodejs-github-bot
added
the
c++
|
Doh! Good catch |
jasnell
approved these changes
Mar 16, 2019
|
Can this be tested for? |
|
@richardlau sure but timeout based test tend to be flaky - or take a long time to have a good security margin. |
|
Yeah, with this one, the values are way too non-deterministic to test
reliably.
…On Fri, Mar 15, 2019, 23:49 Gerhard Stöbich ***@***.***> wrote:
@richardlau <https://github.com/richardlau> sure but timeout based test
tend to be flaky - or take a long time to have a good security margin.
Currently the whole ELD functionality does not testing the actual values
just the presence of them.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#26693 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AAa2eb7AAYiwZJYL65Rtk5rghN6X2ggYks5vXJQCgaJpZM4b3PBz>
.
|
richardlau
approved these changes
Mar 16, 2019
cjihrig
approved these changes
Mar 16, 2019
BridgeAR
added
the
author ready
ZYSzys
approved these changes
Mar 20, 2019
|
Landed in 614a747 🎉 |
targos
pushed a commit
to targos/node
that referenced
this pull request
Mar 27, 2019
reset `ELDHistogram.prev_` before staring timer to ensure that start timer doesn't leak across `disable()` `enable()` calls. PR-URL: nodejs#26693 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Yongsheng Zhang <[email protected]>
targos
pushed a commit
that referenced
this pull request
Mar 27, 2019
reset `ELDHistogram.prev_` before staring timer to ensure that start timer doesn't leak across `disable()` `enable()` calls. PR-URL: #26693 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Yongsheng Zhang <[email protected]>
This was referenced Mar 11, 2021
This was referenced May 25, 2021
This was referenced Apr 7, 2022
This was referenced Jan 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
reset
ELDHistogram.prev_before staring timer to ensure that starttimer doesn't leak across
disable()enable()calls.Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes@jasnell I have seen this nit late during review of #26556 and it's not directly related to your changes. But feel free to integrate it into your PR to avoid a later on merge conflict.