Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lib: use const where possible #26679

Closed
wants to merge 1 commit into from
Closed

lib: use const where possible #26679

wants to merge 1 commit into from

Conversation

JungMinu
Copy link
Member

use const instead of var where possible

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@JungMinu
lib: use const where possible
fb392cc 
use const instead of var where possible
@nodejs-github-bot
Copy link
Collaborator

@JungMinu build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/2920/pipeline

@nodejs-github-bot nodejs-github-bot added dgram Issues and PRs related to the dgram subsystem / UDP. net Issues and PRs related to the net subsystem. repl Issues and PRs related to the REPL subsystem. labels Mar 15, 2019
@Trott
Copy link
Member

Trott commented Mar 15, 2019 •
edited
Loading

We usually reject PRs for the lib directory that are exclusively var -> const like this one. A recent previous example is #26504. See the conversation there for some of the reasoning.

@Trott
Copy link
Member

Trott commented Mar 15, 2019

If you want to try to get a var -> const PR for the lib directory accepted, I'd recommend this approach:

  • Configure ESLint to flag instances of var that could be const. (Don't flag instances that would have to be let.)

  • Auto-fix the entire lib directory.

  • Submit the changed lib code along with the ESLint configuration change.

The PR may still get rejected due to churn etc.! But there is at least some support for the idea that we keep getting these kinds of PRs so it may be time to just fix it once and for all. So it might get accepted.

@BridgeAR BridgeAR mentioned this pull request Mar 26, 2019
Closed
4 tasks
BridgeAR added a commit to BridgeAR/node that referenced this pull request Mar 28, 2019
@BridgeAR
benchmark,lib: var to const
ae93168 
Refs: nodejs#26679
targos pushed a commit that referenced this pull request Mar 30, 2019
@BridgeAR @targos
benchmark,lib: change var to const
f86f573 
Refs: #26679

PR-URL: #26915
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Refael Ackermann <[email protected]>
@BridgeAR
Copy link
Member

BridgeAR commented Apr 1, 2019

Superseded by #26915

@BridgeAR BridgeAR closed this Apr 1, 2019
BethGriggs pushed a commit that referenced this pull request Apr 5, 2019
@BridgeAR @BethGriggs
benchmark,lib: change var to const
c147f64 
Refs: #26679

PR-URL: #26915
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Refael Ackermann <[email protected]>
BethGriggs pushed a commit that referenced this pull request Apr 8, 2019
@BridgeAR @BethGriggs
benchmark,lib: change var to const
0aea4d1 
Refs: #26679

PR-URL: #26915
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Refael Ackermann <[email protected]>
Signed-off-by: Beth Griggs <[email protected]>
@ZYSzys ZYSzys mentioned this pull request Jun 6, 2019
Closed
2 tasks
@kissofire kissofire mentioned this pull request Mar 7, 2021
Open
@aliceUnhinged613 aliceUnhinged613 mentioned this pull request Mar 7, 2021
Open
@ron-a20 ron-a20 mentioned this pull request Mar 8, 2021
Open
@sitedata sitedata mentioned this pull request Mar 8, 2021
Open
@meghasfdc meghasfdc mentioned this pull request Mar 8, 2021
Open
@137717unity 137717unity mentioned this pull request Mar 8, 2021
Open
@Rednickle Rednickle mentioned this pull request Mar 8, 2021
Open
This was referenced Mar 11, 2021
Open
Open
This was referenced May 25, 2021
Open
Open
Open
Open
Open
This was referenced May 25, 2021
Open
Open
Open
Open
Open
This was referenced Apr 7, 2022
Open
Open
Open
Open
Open
Open
Open
Open
Closed
@snyk-bot snyk-bot mentioned this pull request Jan 30, 2023
Open
@wedataintelligence wedataintelligence mentioned this pull request Jan 30, 2023
Open
@snyk-bot snyk-bot mentioned this pull request Jan 30, 2023
Open
@molllyn1 molllyn1 mentioned this pull request Jan 31, 2023
Open
@snyk-bot snyk-bot mentioned this pull request Jan 31, 2023
Open
@baby636 baby636 mentioned this pull request Jan 31, 2023
Open
This was referenced Jan 31, 2023
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
dgram Issues and PRs related to the dgram subsystem / UDP. net Issues and PRs related to the net subsystem. repl Issues and PRs related to the REPL subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@JungMinu @nodejs-github-bot @Trott @BridgeAR