timers: remove dead code and simplify args check #26555
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `setUnrefTimeout` function is never called with more arguments than two. So quite some code was dead and never used. This removes that code and simplifies the args check not to coerce objects to booleans.
nodejs-github-bot
added
the
timers
|
CI https://ci.nodejs.org/job/node-test-pull-request/21392/ @nodejs/timers PTAL |
bnoordhuis
approved these changes
Mar 11, 2019
BridgeAR
added
the
author ready
|
It would be nice to get another review. |
tniessen
approved these changes
Mar 13, 2019
|
Landed in a2bed79 🎉 |
BridgeAR
added a commit
to BridgeAR/node
that referenced
this pull request
Mar 13, 2019
The `setUnrefTimeout` function is never called with more arguments than two. So quite some code was dead and never used. This removes that code and simplifies the args check not to coerce objects to booleans. PR-URL: nodejs#26555 Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Tobias Nießen <[email protected]>
BridgeAR
added a commit
that referenced
this pull request
Mar 14, 2019
The `setUnrefTimeout` function is never called with more arguments than two. So quite some code was dead and never used. This removes that code and simplifies the args check not to coerce objects to booleans. PR-URL: #26555 Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Tobias Nießen <[email protected]>
BridgeAR
added a commit
to BridgeAR/node
that referenced
this pull request
Mar 14, 2019
The `setUnrefTimeout` function is never called with more arguments than two. So quite some code was dead and never used. This removes that code and simplifies the args check not to coerce objects to booleans. PR-URL: nodejs#26555 Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Tobias Nießen <[email protected]>
BridgeAR
added a commit
that referenced
this pull request
Mar 14, 2019
The `setUnrefTimeout` function is never called with more arguments than two. So quite some code was dead and never used. This removes that code and simplifies the args check not to coerce objects to booleans. PR-URL: #26555 Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Tobias Nießen <[email protected]>
This was referenced Mar 11, 2021
This was referenced May 25, 2021
This was referenced Apr 7, 2022
This was referenced Jan 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
setUnrefTimeoutfunction is never called with more argumentsthan two. So quite some code was dead and never used. This removes
that code and simplifies the args check not to coerce objects to
booleans.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes