src: remove redundant cast in string_search.h #26426
Conversation
nodejs-github-bot
added
buffer
|
@gengjiawen I really like that you clean up a lot of code at the moment! As a personal request though: would you be so kind and combine a couple of these in a single PR if they feel somewhat related (e.g., removing a couple of redundant casts)? And it is still good to have small PRs, just maybe not as small. That reduces the overhead that we currently have to review and land the PRs :-) |
BridgeAR
added
the
author ready
@BridgeAR I will try to do it if prs are small next time. But I find it difficulty when some middle commit need to fix. How do you guys manage that? In my current workflow, I just need to switch that branch, fix it and amend the commit. |
|
Landed in 95e3119 🎉 |
PR-URL: nodejs#26426 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]>
PR-URL: nodejs#26426 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]>
PR-URL: #26426 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]>
PR-URL: #26426 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]>
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes