Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

src: make parameter name const reference in method TriggerNodeReport #26397

Closed
wants to merge 1 commit into from
Closed

src: make parameter name const reference in method TriggerNodeReport #26397

wants to merge 1 commit into from

Conversation

gengjiawen
Copy link
Member

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added the c++ Issues and PRs that require attention from people who are familiar with C++. label Mar 2, 2019
@richardlau richardlau added the report Issues and PRs related to process.report. label Mar 2, 2019
@BridgeAR
Copy link
Member

BridgeAR commented Mar 6, 2019

@gengjiawen this needs a rebase

@gengjiawen
Copy link
Member Author

gengjiawen commented Mar 6, 2019 •
edited by BridgeAR
Loading

@BridgeAR Done.

@BridgeAR
Copy link
Member

BridgeAR commented Mar 6, 2019

CI https://ci.nodejs.org/job/node-test-pull-request/21267/

@BridgeAR BridgeAR added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Mar 6, 2019
@BridgeAR
Copy link
Member

BridgeAR commented Mar 6, 2019

Resumed CI https://ci.nodejs.org/job/node-test-pull-request/21283/

@danbev
Copy link
Contributor

danbev commented Mar 7, 2019

Landed in d08a574.

@danbev danbev closed this Mar 7, 2019
danbev pushed a commit that referenced this pull request Mar 7, 2019
@gengjiawen @danbev
src: make parameter name const reference in method TriggerNodeReport
d08a574 
PR-URL: #26397
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
@gengjiawen gengjiawen deleted the string_const_ref branch March 7, 2019 04:12
BridgeAR pushed a commit to BridgeAR/node that referenced this pull request Mar 12, 2019
@gengjiawen @BridgeAR
src: make parameter name const reference in method TriggerNodeReport
539a9c0 
PR-URL: nodejs#26397
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
@BridgeAR BridgeAR mentioned this pull request Mar 13, 2019
Merged
BridgeAR pushed a commit that referenced this pull request Mar 14, 2019
@gengjiawen @BridgeAR
src: make parameter name const reference in method TriggerNodeReport
c7bd21c 
PR-URL: #26397
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BridgeAR BridgeAR BridgeAR approved these changes

@richardlau richardlau richardlau approved these changes

@addaleax addaleax addaleax approved these changes

@jasnell jasnell jasnell approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. c++ Issues and PRs that require attention from people who are familiar with C++. report Issues and PRs related to process.report.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@gengjiawen @BridgeAR @danbev @jasnell @addaleax @richardlau @nodejs-github-bot