src: remove inspector main_thread_request_ field #26137
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is redundant to the platform notification mechanism, and the handle may not be cleaned up util we attempt to close the loop. Refs: nodejs#26089 Refs: nodejs#26006
nodejs-github-bot
added
the
c++
4 tasks
eugeneo
approved these changes
Feb 15, 2019
joyeecheung
approved these changes
Feb 16, 2019
addaleax
added
the
author ready
|
Landed in c583245 |
addaleax
added a commit
that referenced
this pull request
Feb 17, 2019
This is redundant to the platform notification mechanism, and the handle may not be cleaned up util we attempt to close the loop. Refs: #26089 Refs: #26006 PR-URL: #26137 Reviewed-By: Eugene Ostroukhov <[email protected]> Reviewed-By: Joyee Cheung <[email protected]>
addaleax
added a commit
that referenced
this pull request
Feb 18, 2019
This is redundant to the platform notification mechanism, and the handle may not be cleaned up util we attempt to close the loop. Refs: #26089 Refs: #26006 PR-URL: #26137 Reviewed-By: Eugene Ostroukhov <[email protected]> Reviewed-By: Joyee Cheung <[email protected]>
addaleax
added a commit
to addaleax/node
that referenced
this pull request
Feb 24, 2019
This was overlooked in c583245. Refs: nodejs#26137
2 tasks
Merged
rvagg
pushed a commit
that referenced
this pull request
Feb 28, 2019
This is redundant to the platform notification mechanism, and the handle may not be cleaned up util we attempt to close the loop. Refs: #26089 Refs: #26006 PR-URL: #26137 Reviewed-By: Eugene Ostroukhov <[email protected]> Reviewed-By: Joyee Cheung <[email protected]>
addaleax
added a commit
that referenced
this pull request
Mar 1, 2019
This was overlooked in c583245. Refs: #26137 PR-URL: #26295 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Tobias Nießen <[email protected]>
addaleax
added a commit
that referenced
this pull request
Mar 1, 2019
This was overlooked in c583245. Refs: #26137 PR-URL: #26295 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Tobias Nießen <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is redundant to the platform notification mechanism, and
the handle may not be cleaned up util we attempt to close the loop.
Refs: #26089
Refs: #26006
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes