test: add arg to narrow http benchmark test #26101
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Special CI job: https://ci.nodejs.org/job/node-test-commit-custom-suites/872/ |
refack
added
benchmark
|
An alternative could be to rename the new arg to |
|
Please 👍 to fast-track since ATM the daily master job is failing |
2 tasks
Trott
reviewed
Feb 14, 2019
| @@ -29,7 +29,8 @@ runBenchmark('http', | |||
| 'n=1', | |||
| 'res=normal', | |||
| 'type=asc', | |||
| 'value=X-Powered-By' | |||
| 'value=X-Powered-By', | |||
| 'headerDuplicates=1', | |||
There was a problem hiding this comment.
Can you relocate it higher in the list to keep the list in alphabetical order?
There was a problem hiding this comment.
Can you relocate it higher in the list to keep the list in alphabetical order?
Argh, never mind, it's already not alphabetical, just mostly alphabetical. Anyway, LGTM, but nit: Would prefer to alphabetize the list.
(Also, agree that n is probably better. The headers aren't duplicates. They're similarly-named.)
Trott
approved these changes
Feb 14, 2019
addaleax
approved these changes
Feb 14, 2019
cjihrig
approved these changes
Feb 14, 2019
PR-URL: nodejs#26101 Reviewed-By: Weijia Wang <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
refack
force-pushed
the
only-one-bench-http-incoming_headers
branch
from
182ec22 to
fe58bef
Compare
|
Fast-tracked with 3 upvotes @Trott I'll make a follow up clean PR. |
|
Refactoring PR #26119 |
targos
pushed a commit
that referenced
this pull request
Feb 15, 2019
PR-URL: #26101 Reviewed-By: Weijia Wang <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
refack
added a commit
to refack/node
that referenced
this pull request
Feb 18, 2019
PR-URL: nodejs#26119 Refs: nodejs#26101 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: James M Snell <[email protected]>
addaleax
pushed a commit
that referenced
this pull request
Feb 19, 2019
PR-URL: #26119 Refs: #26101 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: James M Snell <[email protected]>
Merged
rvagg
pushed a commit
that referenced
this pull request
Feb 28, 2019
PR-URL: #26101 Reviewed-By: Weijia Wang <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
rvagg
pushed a commit
that referenced
this pull request
Feb 28, 2019
PR-URL: #26119 Refs: #26101 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: James M Snell <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Recent changes (da0dc51) added a new benchmark (
benchmark/http/incoming_headers.js) which takes a new arg (headerDuplicates).This PR passes a value for that arg so that during the sanity test this benchmark will run only once.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes