Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

src: remove unused method in env.h #25934

Closed
wants to merge 1 commit into from
Closed

src: remove unused method in env.h #25934

wants to merge 1 commit into from

Conversation

gengjiawen
Copy link
Member

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added the c++ Issues and PRs that require attention from people who are familiar with C++. label Feb 5, 2019
@gengjiawen
Copy link
Member Author

@addaleax Also this one, thanks.

@danbev
Copy link
Contributor

danbev commented Feb 8, 2019

CI: https://ci.nodejs.org/job/node-test-pull-request/20659/

@lpinca
Copy link
Member

lpinca commented Feb 9, 2019

Resume CI: https://ci.nodejs.org/job/node-test-pull-request/20683/

@lpinca
Copy link
Member

lpinca commented Feb 9, 2019

Landed in c2d374f.

@lpinca lpinca closed this Feb 9, 2019
lpinca pushed a commit that referenced this pull request Feb 9, 2019
@gengjiawen @lpinca
src: remove unused method in env.h
c2d374f 
Signed-off-by: gengjiawen <[email protected]>

PR-URL: #25934
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
@targos targos mentioned this pull request Feb 10, 2019
Closed
This was referenced Apr 23, 2019
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lpinca lpinca lpinca approved these changes

@addaleax addaleax addaleax approved these changes

@jasnell jasnell jasnell approved these changes

Assignees
No one assigned
Labels
c++ Issues and PRs that require attention from people who are familiar with C++.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@gengjiawen @danbev @lpinca @jasnell @addaleax @targos @nodejs-github-bot