Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tls: null not valid as a renegotiate callback #25929

Closed
wants to merge 1 commit into from
Closed

tls: null not valid as a renegotiate callback #25929

wants to merge 1 commit into from

Conversation

sam-github
Copy link
Contributor

@sam-github sam-github commented Feb 4, 2019 •
edited
Loading

Allow undefined as a callback, but do not allow null.

Belatedly respond to #25876 (comment)

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines

@sam-github
tls: null not valid as a renegotiate callback
ce0fcdc 
Allow undefined as a callback, but do not allow null.
@sam-github sam-github requested a review from cjihrig February 4, 2019 18:22
@nodejs-github-bot
Copy link
Collaborator

@sam-github build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/2508/pipeline

@nodejs-github-bot nodejs-github-bot added the tls Issues and PRs related to the tls subsystem. label Feb 4, 2019
@sam-github
Copy link
Contributor Author

ci: https://ci.nodejs.org/job/node-test-commit/25593/

@addaleax
Copy link
Member

addaleax commented Feb 6, 2019

Landed in 00d49ad

@addaleax addaleax closed this Feb 6, 2019
addaleax pushed a commit that referenced this pull request Feb 6, 2019
@sam-github @addaleax
tls: null not valid as a renegotiate callback
00d49ad 
Allow undefined as a callback, but do not allow null.

PR-URL: #25929
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Anatoli Papirovski <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Minwoo Jung <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@sam-github sam-github mentioned this pull request Feb 6, 2019
Closed
4 tasks
@sam-github sam-github deleted the only-undef-or-fn-for-reneg branch February 6, 2019 23:11
@addaleax
Copy link
Member

addaleax commented Feb 8, 2019

@sam-github If I understood you correctly, this should be labelled dont-land-on-v11.x.

This was referenced Apr 23, 2019
Closed
Closed
Closed
Closed
Closed
Closed
Closed
This was referenced Apr 23, 2019
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BridgeAR BridgeAR BridgeAR approved these changes

@JungMinu JungMinu JungMinu approved these changes

@cjihrig cjihrig cjihrig approved these changes

@lpinca lpinca lpinca approved these changes

@jasnell jasnell jasnell approved these changes

@apapirovski apapirovski apapirovski approved these changes

Assignees
No one assigned
Labels
tls Issues and PRs related to the tls subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@sam-github @nodejs-github-bot @addaleax @apapirovski @jasnell @lpinca @cjihrig @JungMinu @BridgeAR