Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

report: include information about event loop itself #25906

Closed
wants to merge 2 commits into from
Closed

report: include information about event loop itself #25906

wants to merge 2 commits into from

Conversation

addaleax
Copy link
Member

@addaleax addaleax commented Feb 3, 2019

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines

@nodejs-github-bot
Copy link
Collaborator

@addaleax build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/2500/pipeline

@nodejs-github-bot nodejs-github-bot added the c++ Issues and PRs that require attention from people who are familiar with C++. label Feb 3, 2019
@addaleax addaleax added the report Issues and PRs related to process.report. label Feb 3, 2019
@addaleax
Copy link
Member Author

addaleax commented Feb 3, 2019

(I’m marking this as blocked on #25910, and will update this PR to also use a hex string once that one lands.)

@addaleax addaleax added the blocked PRs that are blocked by other issues or PRs. label Feb 3, 2019
@addaleax addaleax added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. and removed blocked PRs that are blocked by other issues or PRs. labels Feb 5, 2019
@addaleax
Copy link
Member Author

addaleax commented Feb 5, 2019

Okay, rebased this against #25910.

CI: https://ci.nodejs.org/job/node-test-pull-request/20591/

@addaleax
Copy link
Member Author

addaleax commented Feb 5, 2019

Resume CI: https://ci.nodejs.org/job/node-test-pull-request/20601/

@addaleax
Copy link
Member Author

addaleax commented Feb 6, 2019

Landed in 91adbe1

@addaleax addaleax closed this Feb 6, 2019
@addaleax addaleax deleted the node-report-loop branch February 6, 2019 14:46
addaleax added a commit that referenced this pull request Feb 6, 2019
@addaleax
report: include information about event loop itself
91adbe1 
PR-URL: #25906
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: James M Snell <[email protected]>
addaleax added a commit that referenced this pull request Feb 6, 2019
@addaleax
report: include information about event loop itself
6c51ec3 
PR-URL: #25906
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@targos targos mentioned this pull request Feb 14, 2019
Merged
This was referenced Feb 15, 2019
Closed
Closed
Closed
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@richardlau richardlau richardlau approved these changes

@cjihrig cjihrig cjihrig approved these changes

@jasnell jasnell jasnell approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. c++ Issues and PRs that require attention from people who are familiar with C++. report Issues and PRs related to process.report.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@addaleax @nodejs-github-bot @jasnell @cjihrig @richardlau