Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

worker: remove undocumented .onclose property #25904

Closed
wants to merge 1 commit into from

Conversation

Trott
Copy link
Member

@Trott Trott commented Feb 3, 2019

Remove setting of a 'close' event handler on MessagePort through the use
of an .onclose property. We don't use this convention anywhere else in
our codebase for 'close' events, this feature is undocumented, and we
don't test it.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

Sorry, something went wrong.

Remove setting of a 'close' event handler on MessagePort through the use
of an `.onclose` property. We don't use this convention anywhere else in
our codebase for 'close' events, this feature is undocumented, and we
don't test it.
@Trott Trott requested a review from addaleax February 3, 2019 10:13
@nodejs-github-bot nodejs-github-bot added the worker Issues and PRs related to Worker support. label Feb 3, 2019
@Trott
Copy link
Member Author

Trott commented Feb 3, 2019

Originally added in e7a2367.

An alternative would be to document and test it. I'm inclined to remove it--YAGNI and all that.

@Trott
Copy link
Member Author

Trott commented Feb 5, 2019

@nodejs/workers

@Trott
Copy link
Member Author

Trott commented Feb 5, 2019

@Trott
Copy link
Member Author

Trott commented Feb 6, 2019

@nodejs/collaborators Could use reviews...

Copy link
Member

@benjamingr benjamingr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure. We can wait on it

@Trott Trott added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Feb 6, 2019
@Trott
Copy link
Member Author

Trott commented Feb 6, 2019

Landed in 6da82b1

@Trott Trott closed this Feb 6, 2019
Trott added a commit to Trott/io.js that referenced this pull request Feb 6, 2019
Remove setting of a 'close' event handler on MessagePort through the use
of an `.onclose` property. We don't use this convention anywhere else in
our codebase for 'close' events, this feature is undocumented, and we
don't test it.

PR-URL: nodejs#25904
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Yuta Hiroto <[email protected]>
Reviewed-By: Ujjwal Sharma <[email protected]>
addaleax pushed a commit that referenced this pull request Feb 6, 2019
Remove setting of a 'close' event handler on MessagePort through the use
of an `.onclose` property. We don't use this convention anywhere else in
our codebase for 'close' events, this feature is undocumented, and we
don't test it.

PR-URL: #25904
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Yuta Hiroto <[email protected]>
Reviewed-By: Ujjwal Sharma <[email protected]>
@targos targos mentioned this pull request Feb 14, 2019
@Trott Trott deleted the rm-onclose branch January 13, 2022 22:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. worker Issues and PRs related to Worker support.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants