Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test,tracing: use close event to wait for stdio #25894

Closed
wants to merge 1 commit into from
Closed

test,tracing: use close event to wait for stdio #25894

wants to merge 1 commit into from

Conversation

addaleax
Copy link
Member

@addaleax addaleax commented Feb 2, 2019

Use 'close' rather than 'exit' to make sure that all stdio
has been captured by the time that the event handler is run.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines

@addaleax
test,tracing: use close event to wait for stdio
cf13348 
Use `'close'` rather than `'exit'` to make sure that all stdio
has been captured by the time that the event handler is run.
@nodejs-github-bot
Copy link
Collaborator

@addaleax build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/2491/pipeline

@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label Feb 2, 2019
@addaleax
Copy link
Member Author

addaleax commented Feb 3, 2019

CI: https://ci.nodejs.org/job/node-test-pull-request/20552/

@addaleax
Copy link
Member Author

addaleax commented Feb 5, 2019

Resume CI: https://ci.nodejs.org/job/node-test-pull-request/20594/

@addaleax
Copy link
Member Author

addaleax commented Feb 5, 2019

Landed in 8d63f40

@addaleax addaleax closed this Feb 5, 2019
@addaleax addaleax deleted the test-trace-events-close branch February 5, 2019 20:55
addaleax added a commit that referenced this pull request Feb 5, 2019
@addaleax
test,tracing: use close event to wait for stdio
8d63f40 
Use `'close'` rather than `'exit'` to make sure that all stdio
has been captured by the time that the event handler is run.

PR-URL: #25894
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Anto Aravinth <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
addaleax added a commit that referenced this pull request Feb 6, 2019
@addaleax
test,tracing: use close event to wait for stdio
2009f18 
Use `'close'` rather than `'exit'` to make sure that all stdio
has been captured by the time that the event handler is run.

PR-URL: #25894
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Anto Aravinth <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
@targos targos mentioned this pull request Feb 14, 2019
Merged
This was referenced Feb 15, 2019
Closed
Closed
Closed
Closed
Closed
Closed
@snyk-bot snyk-bot mentioned this pull request Aug 11, 2020
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cjihrig cjihrig cjihrig approved these changes

@lpinca lpinca lpinca approved these changes

@antsmartian antsmartian antsmartian approved these changes

@Trott Trott Trott approved these changes

Assignees
No one assigned
Labels
test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@addaleax @nodejs-github-bot @Trott @antsmartian @lpinca @cjihrig