test: relax expectations in test-icu-transcode #25866
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@nodejs/intl @nodejs/i18n |
addaleax
approved these changes
Feb 1, 2019
TimothyGu
approved these changes
Feb 2, 2019
addaleax
added
the
author ready
|
Looks again like some Jenkins related issue. |
|
Resume CI again: https://ci.nodejs.org/job/node-test-commit/25596/ (✔️) |
|
Landed in 793c630. |
danbev
pushed a commit
that referenced
this pull request
Feb 5, 2019
Chromium's ICU considers "latin1" and "ascii" to mean Windows-1252, which is consistent with [WHATWG spec](https://encoding.spec.whatwg.org/#names-and-labels). If linked against Chromium's ICU, Node.js therefore fails `test/parallel/test-icu-transcode`. PR-URL: #25866 Refs: #25851 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Tiancheng "Timothy" Gu <[email protected]>
addaleax
pushed a commit
that referenced
this pull request
Feb 6, 2019
Chromium's ICU considers "latin1" and "ascii" to mean Windows-1252, which is consistent with [WHATWG spec](https://encoding.spec.whatwg.org/#names-and-labels). If linked against Chromium's ICU, Node.js therefore fails `test/parallel/test-icu-transcode`. PR-URL: #25866 Refs: #25851 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Tiancheng "Timothy" Gu <[email protected]>
Merged
This was referenced Feb 15, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Chromium's ICU considers "latin1" and "ascii" to mean Windows-1252, which is consistent with WHATWG spec. If linked against Chromium's ICU, Node.js therefore fails
test/parallel/test-icu-transcode.Refs: #25851
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes