src,lib: remove dead process.binding() code
#25829
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
the
lib / src
joyeecheung
approved these changes
Jan 30, 2019
cjihrig
approved these changes
Jan 30, 2019
addaleax
added
the
author ready
antsmartian
approved these changes
Jan 31, 2019
devsnek
approved these changes
Jan 31, 2019
| @@ -33,9 +33,6 @@ enum { | |||
| nullptr}; \ | |||
| void _register_##modname() { node_module_register(&_module); } | |||
|
|
|||
| #define NODE_BUILTIN_MODULE_CONTEXT_AWARE(modname, regfunc) \ | |||
bnoordhuis
approved these changes
Jan 31, 2019
There was a problem hiding this comment.
By the way and apropos nothing, node_binding.h includes itself. Accidental change from 13abc6a?
| env->ThrowError("Built-in module self-registered."); | ||
| return false; | ||
| } | ||
| CHECK_EQ(mp->nm_flags & NM_F_BUILTIN, 0); |
There was a problem hiding this comment.
Maybe invert this to CHECK_EQ(0, mp->nm_flags & ~(NM_F_INTERNAL | NM_F_LINKED))? That way you can get rid of NM_F_BUILTIN and it'll also help catch accidental corruption.
There was a problem hiding this comment.
I guess we aren’t introducing new flags too often, but maybe at some point we’ll want to add a new flag in a backwards-compatible way?
Yeah, removed that – thanks for noticing 👍 |
|
ping @addaleax this needs a rebase |
There are no non-internal builtin modules left, so this should be safe to remove to a large degree.
addaleax
force-pushed
the
dead-process-binding
branch
from
b14fbcd to
4602232
Compare
|
@joyeecheung Thanks for the ping! New CI: https://ci.nodejs.org/job/node-test-pull-request/20526/ |
|
Landed in 270ffb0 |
addaleax
added a commit
that referenced
this pull request
Feb 3, 2019
There are no non-internal builtin modules left, so this should be safe to remove to a large degree. PR-URL: #25829 Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Anto Aravinth <[email protected]> Reviewed-By: Gus Caplan <[email protected]> Reviewed-By: Ben Noordhuis <[email protected]>
|
(I’m adding |
|
This lands cleanly on v11.x-staging and tests pass but is it safe to land? |
|
Feel free to land it on staging if the answer is yes. |
addaleax
added a commit
that referenced
this pull request
Feb 10, 2019
There are no non-internal builtin modules left, so this should be safe to remove to a large degree. PR-URL: #25829 Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Anto Aravinth <[email protected]> Reviewed-By: Gus Caplan <[email protected]> Reviewed-By: Ben Noordhuis <[email protected]>
Merged
This was referenced Feb 15, 2019
This was referenced Feb 15, 2019
deepak1556
added a commit
to electron/electron
that referenced
this pull request
Mar 6, 2019
NODE_BUILTING_MODULE_CONTEXT_AWARE and process.binding are removed in nodejs/node#25829. This changes uses the alternative available without any functionality change.
6 tasks
deepak1556
added a commit
to electron/electron
that referenced
this pull request
Mar 7, 2019
NODE_BUILTING_MODULE_CONTEXT_AWARE and process.binding are removed in nodejs/node#25829. This changes uses the alternative available without any functionality change.
nornagon
pushed a commit
to electron/electron
that referenced
this pull request
Mar 8, 2019
…17247) * refactor: load electron builtin modules with process._linkedBinding NODE_BUILTING_MODULE_CONTEXT_AWARE and process.binding are removed in nodejs/node#25829. This changes uses the alternative available without any functionality change. * chore: roll node
nitsakh
pushed a commit
to electron/electron
that referenced
this pull request
Mar 27, 2019
…17247) * refactor: load electron builtin modules with process._linkedBinding NODE_BUILTING_MODULE_CONTEXT_AWARE and process.binding are removed in nodejs/node#25829. This changes uses the alternative available without any functionality change. * chore: roll node
nitsakh
pushed a commit
to electron/electron
that referenced
this pull request
Mar 28, 2019
…17247) * refactor: load electron builtin modules with process._linkedBinding NODE_BUILTING_MODULE_CONTEXT_AWARE and process.binding are removed in nodejs/node#25829. This changes uses the alternative available without any functionality change. * chore: roll node
zcbenz
pushed a commit
to electron/electron
that referenced
this pull request
Apr 10, 2019
…17247) * refactor: load electron builtin modules with process._linkedBinding NODE_BUILTING_MODULE_CONTEXT_AWARE and process.binding are removed in nodejs/node#25829. This changes uses the alternative available without any functionality change. * chore: roll node
ckerr
pushed a commit
to electron/electron
that referenced
this pull request
Apr 16, 2019
* fix: backport boringssl patches for node compat * refactor: prevent node macros from overriding base (#17178) * fix: backport boring ssl patch OPENSSL_clear_free * refactor: load electron builtin modules with process._linkedBinding (#17247) * refactor: load electron builtin modules with process._linkedBinding NODE_BUILTING_MODULE_CONTEXT_AWARE and process.binding are removed in nodejs/node#25829. This changes uses the alternative available without any functionality change. * chore: roll node * fix: add boringssl backport to support node upgrade * fix: Update node_includes.h, add DCHECK macros * fix: Update node Debug Options parser usage * fix: Fix asar setup * fix: using v8Util in isolated context * fix: make "process" available in preload scripts * fix: use proper options parser and remove setting of _breakFirstLine _breakFirstLine was being set on the process, but that has changed in node 12 and so is no longer needed. Node will handle it properly when --inspect-brk is provided * fix: process.binding => _linkedBinding in sandboxed isolated preload * chore: update node dep sha * fix: make original-fs work with streams
kiku-jw
pushed a commit
to kiku-jw/electron
that referenced
this pull request
May 16, 2019
…lectron#17247) * refactor: load electron builtin modules with process._linkedBinding NODE_BUILTING_MODULE_CONTEXT_AWARE and process.binding are removed in nodejs/node#25829. This changes uses the alternative available without any functionality change. * chore: roll node
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are no non-internal builtin modules left, so this
should be safe to remove to a large degree.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes