lib: save primordials during bootstrap and use it in builtins #25816
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patches changes the `safe_globals` internal module into a script that gets run during bootstrap and saves JavaScript builtins (primordials) into an object that is available for all other builtin modules to access lexically later.
nodejs-github-bot
added
the
lib / src
devsnek
reviewed
Jan 30, 2019
bmeck
suggested changes
Jan 30, 2019
addaleax
approved these changes
Jan 30, 2019
bmeck
reviewed
Jan 30, 2019
@devsnek Do you have a good API to test this in mind? This test would depend on the implementation details of the API and if the API being tested is changed we would have to look for another one that uses these globals after user code execution starts. Or is there already any tests for the previous |
bmeck
reviewed
Jan 30, 2019
bmeck
approved these changes
Jan 30, 2019
devsnek
approved these changes
Jan 30, 2019
joyeecheung
added
the
author ready
|
Landed in 39d9221 |
|
@joyeecheung This also needs to be backported to v11.x manually |
targos
pushed a commit
that referenced
this pull request
Feb 10, 2019
This patches changes the `safe_globals` internal module into a script that gets run during bootstrap and saves JavaScript builtins (primordials) into an object that is available for all other builtin modules to access lexically later. PR-URL: #25816 Refs: #18795 Reviewed-By: Bradley Farias <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Gus Caplan <[email protected]>
Merged
This was referenced Feb 15, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patches changes the
safe_globalsinternal module into ascript that gets run during bootstrap and saves JavaScript builtins
(primordials) into an object that is available for all other builtin
modules to access lexically later.
Refs: #18795
cc @hashseed @devsnek @bmeck
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes