-
Notifications
You must be signed in to change notification settings - Fork 30k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build: make compress_json python3 compatible #25582
build: make compress_json python3 compatible #25582
Conversation
This patch replaces a usage of `map` with list comprehension, which makes the script Python 3 compatiable.
I'm looking at the history, and it seems like this is a node-core only tool. Maybe we can eliminate it. /CC @nodejs/v8-inspector |
@refack Good call. If we can get rid of this, one less file to maintain. |
What is the question? I introduced it to shrink the size of the embedded JSON. Currently it reduces its size from about 140k to 15k. |
Re-run of failing node-test-commit-linux-containered ✔️ |
Landed in b31b84d. |
This patch replaces a usage of `map` with list comprehension, which makes the script Python 3 compatiable. PR-URL: #25582 Reviewed-By: Refael Ackermann <[email protected]>
This patch replaces a usage of `map` with list comprehension, which makes the script Python 3 compatiable. PR-URL: #25582 Reviewed-By: Refael Ackermann <[email protected]>
This patch replaces a usage of `map` with list comprehension, which makes the script Python 3 compatiable. PR-URL: #25582 Reviewed-By: Refael Ackermann <[email protected]>
This patch replaces a usage of `map` with list comprehension, which makes the script Python 3 compatiable. PR-URL: #25582 Reviewed-By: Refael Ackermann <[email protected]>
This patch replaces a usage of `map` with list comprehension, which makes the script Python 3 compatiable. PR-URL: #25582 Reviewed-By: Refael Ackermann <[email protected]>
This patch replaces a usage of `map` with list comprehension, which makes the script Python 3 compatiable. PR-URL: nodejs#25582 Reviewed-By: Refael Ackermann <[email protected]> (cherry picked from commit b31b84d)
This patch replaces a usage of
map
with list comprehension,which makes the script Python 3 compatiable.
Checklist
make -j4 test
(UNIX), orvcbuild test
(Windows) passescc @nodejs/python @cclauss