Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

inspector, test: verify reported console message #25455

Closed
wants to merge 2 commits into from
Closed

inspector, test: verify reported console message #25455

wants to merge 2 commits into from

Conversation

eugeneo
Copy link
Contributor

@eugeneo eugeneo commented Jan 11, 2019

Many Inspector protocol clients rely on the top frame reported for the
console messages. This test makes sure correct location is reported.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines

@nodejs-github-bot
Copy link
Collaborator

@eugeneo sadly an error occured when I tried to trigger a build :(

@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label Jan 11, 2019
@eugeneo eugeneo added the inspector Issues and PRs related to the V8 inspector protocol label Jan 11, 2019
@eugeneo eugeneo mentioned this pull request Jan 11, 2019
Closed
4 tasks
@eugeneo eugeneo requested a review from joyeecheung January 11, 2019 22:52
@eugeneo
inspector, test: verify reported console message
b021701 
Many Inspector protocol clients rely on the top frame reported for the
console messages. This test makes sure correct location is reported.
joyeecheung
joyeecheung approved these changes Jan 12, 2019
View reviewed changes
Copy link
Member

@joyeecheung joyeecheung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, LGTM with a suggestion

test/parallel/test-inspector-console-top-frame.js Show resolved Hide resolved
@eugeneo
Copy link
Contributor Author

eugeneo commented Jan 14, 2019

CI: https://ci.nodejs.org/job/node-test-pull-request/20116/

@eugeneo
Copy link
Contributor Author

eugeneo commented Jan 14, 2019

There are some failures on CI, but they are unrelated as this test case passes...

@joyeecheung
Copy link
Member

Resume: https://ci.nodejs.org/job/node-test-pull-request/20137/

@joyeecheung joyeecheung added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Jan 15, 2019
@joyeecheung
Copy link
Member

Resume: https://ci.nodejs.org/job/node-test-pull-request/20147/

@joyeecheung
Copy link
Member

Landed in c7ec5e4

joyeecheung pushed a commit to joyeecheung/node that referenced this pull request Jan 16, 2019
@eugeneo @joyeecheung
inspector, test: verify reported console message
c7ec5e4 
Many Inspector protocol clients rely on the top frame reported for the
console messages. This test makes sure correct location is reported.

PR-URL: nodejs#25455
Reviewed-By: Joyee Cheung <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: James M Snell <[email protected]>
This was referenced Jan 16, 2019
Closed
Closed
Closed
BridgeAR pushed a commit that referenced this pull request Jan 16, 2019
@eugeneo @BridgeAR
inspector, test: verify reported console message
3061cb5 
Many Inspector protocol clients rely on the top frame reported for the
console messages. This test makes sure correct location is reported.

PR-URL: #25455
Reviewed-By: Joyee Cheung <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@BridgeAR BridgeAR mentioned this pull request Jan 16, 2019
Merged
BridgeAR pushed a commit to BridgeAR/node that referenced this pull request Jan 16, 2019
@eugeneo @BridgeAR
inspector, test: verify reported console message
f4e18cd 
Many Inspector protocol clients rely on the top frame reported for the
console messages. This test makes sure correct location is reported.

PR-URL: nodejs#25455
Reviewed-By: Joyee Cheung <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: James M Snell <[email protected]>
BridgeAR pushed a commit to BridgeAR/node that referenced this pull request Jan 17, 2019
@eugeneo @BridgeAR
inspector, test: verify reported console message
cb73fed 
Many Inspector protocol clients rely on the top frame reported for the
console messages. This test makes sure correct location is reported.

PR-URL: nodejs#25455
Reviewed-By: Joyee Cheung <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@MylesBorins MylesBorins mentioned this pull request Jan 24, 2019
Merged
BethGriggs pushed a commit that referenced this pull request Apr 29, 2019
@eugeneo @BethGriggs
inspector, test: verify reported console message
3babfdf 
Many Inspector protocol clients rely on the top frame reported for the
console messages. This test makes sure correct location is reported.

PR-URL: #25455
Reviewed-By: Joyee Cheung <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@BethGriggs BethGriggs mentioned this pull request May 1, 2019
Merged
BethGriggs pushed a commit that referenced this pull request May 10, 2019
@eugeneo @BethGriggs
inspector, test: verify reported console message
b9c4b79 
Many Inspector protocol clients rely on the top frame reported for the
console messages. This test makes sure correct location is reported.

PR-URL: #25455
Reviewed-By: Joyee Cheung <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: James M Snell <[email protected]>
MylesBorins pushed a commit that referenced this pull request May 16, 2019
@eugeneo @MylesBorins
inspector, test: verify reported console message
cbc428c 
Many Inspector protocol clients rely on the top frame reported for the
console messages. This test makes sure correct location is reported.

PR-URL: #25455
Reviewed-By: Joyee Cheung <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: James M Snell <[email protected]>
This was referenced May 29, 2019
Closed
Closed
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joyeecheung joyeecheung joyeecheung approved these changes

@cjihrig cjihrig cjihrig approved these changes

@lpinca lpinca lpinca approved these changes

@addaleax addaleax addaleax approved these changes

@jasnell jasnell jasnell approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. inspector Issues and PRs related to the V8 inspector protocol test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@eugeneo @nodejs-github-bot @joyeecheung @jasnell @addaleax @lpinca @cjihrig