Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: document that stream.on('close') was changed in Node 10. #25413

Closed
wants to merge 1 commit into from
Closed

docs: document that stream.on('close') was changed in Node 10. #25413

wants to merge 1 commit into from

Conversation

mcollina
Copy link
Member

@mcollina mcollina commented Jan 9, 2019

See: #25373
See: #18438

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines

@nodejs-github-bot
Copy link
Collaborator

@mcollina build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/2200/pipeline

@nodejs-github-bot nodejs-github-bot added doc Issues and PRs related to the documentations. stream Issues and PRs related to the stream subsystem. labels Jan 9, 2019
@mcollina
Copy link
Member Author

mcollina commented Jan 9, 2019

cc @mafintosh

@mcollina mcollina requested review from addaleax and mafintosh January 9, 2019 12:12
sam-github
sam-github reviewed Jan 9, 2019
View reviewed changes
doc/api/stream.md Outdated Show resolved Hide resolved
sam-github added a commit to sam-github/node that referenced this pull request Jan 9, 2019
@sam-github
doc: wrap and punctuate YAML description text
ad5cc6b 
stream.md was the only YAML in doc/api that was using `>` for line
continuation, and only used it for a few descriptions, most used the
same wrapping style the rest of the documentation does.

Also added punctuation and capitialization to a few description
sentences.

Fixes: nodejs#25413 (comment)
@sam-github sam-github mentioned this pull request Jan 9, 2019
Closed
3 tasks
@mcollina
Copy link
Member Author

mcollina commented Jan 9, 2019

@sam-github do you prefer this to rebase on top of #25419?

vsemozhetbyt
vsemozhetbyt reviewed Jan 9, 2019
View reviewed changes
doc/api/stream.md Outdated Show resolved Hide resolved
vsemozhetbyt
vsemozhetbyt reviewed Jan 9, 2019
View reviewed changes
doc/api/stream.md Outdated Show resolved Hide resolved
@sam-github
Copy link
Contributor

@mcollina sure, rebase or squash and close my PR, if you wish. If you don't, I'll just rebase #25419 onto master once this lands, and cleanup there. Its nbd either way.

@mcollina
Copy link
Member Author

mcollina commented Jan 9, 2019

No I mean, you land that, and then I amend this one? Or the contrary?

@sam-github
Copy link
Contributor

Actually, #25419 was fast-tracked so I guess rebasing this one would be the way to go. Sorry, I process github notifications sequentially!

@sam-github
Copy link
Contributor

And it landed (I'm sure you'll notice).

@sam-github sam-github closed this in c2d8a54 Jan 9, 2019
@mcollina mcollina reopened this Jan 9, 2019
@mcollina
Copy link
Member Author

mcollina commented Jan 9, 2019

Reopening this one because it was closed by github.

@mcollina
Copy link
Member Author

CI-lite: https://ci.nodejs.org/job/node-test-pull-request-lite-pipeline/2221/

@mcollina
Copy link
Member Author

mcollina commented Jan 10, 2019 •
edited
Loading

@sam-github @vsemozhetbyt check it out!

@mcollina
Copy link
Member Author

Landed in 18d3aeb

@mcollina mcollina closed this Jan 12, 2019
@mcollina mcollina deleted the close-event-stream branch January 12, 2019 10:43
mcollina added a commit that referenced this pull request Jan 12, 2019
@mcollina
doc: document that stream.on('close') was changed in Node 10
18d3aeb 
See: #25373
See: #18438

PR-URL: #25413
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Sam Roberts <[email protected]>
addaleax pushed a commit that referenced this pull request Jan 14, 2019
@sam-github @addaleax
doc: wrap and punctuate YAML description text
f58b530 
stream.md was the only YAML in doc/api that was using `>` for line
continuation, and only used it for a few descriptions, most used the
same wrapping style the rest of the documentation does.

Also added punctuation and capitialization to a few description
sentences.

Fixes: #25413 (comment)

PR-URL: #25419
Fixes: #25413
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Vse Mozhet Byt <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
addaleax pushed a commit that referenced this pull request Jan 14, 2019
@mcollina @addaleax
doc: document that stream.on('close') was changed in Node 10
b67c4b4 
See: #25373
See: #18438

PR-URL: #25413
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Sam Roberts <[email protected]>
@BridgeAR BridgeAR mentioned this pull request Jan 16, 2019
Merged
BridgeAR pushed a commit to BridgeAR/node that referenced this pull request Jan 16, 2019
@sam-github @BridgeAR
doc: wrap and punctuate YAML description text
4624a5d 
stream.md was the only YAML in doc/api that was using `>` for line
continuation, and only used it for a few descriptions, most used the
same wrapping style the rest of the documentation does.

Also added punctuation and capitialization to a few description
sentences.

Fixes: nodejs#25413 (comment)

PR-URL: nodejs#25419
Fixes: nodejs#25413
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Vse Mozhet Byt <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
BridgeAR pushed a commit to BridgeAR/node that referenced this pull request Jan 16, 2019
@mcollina @BridgeAR
doc: document that stream.on('close') was changed in Node 10
f23b4c3 
See: nodejs#25373
See: nodejs#18438

PR-URL: nodejs#25413
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Sam Roberts <[email protected]>
@MylesBorins MylesBorins mentioned this pull request Jan 24, 2019
Merged
BethGriggs pushed a commit that referenced this pull request Apr 28, 2019
@mcollina @BethGriggs
doc: document that stream.on('close') was changed in Node 10
f7491d4 
See: #25373
See: #18438

PR-URL: #25413
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Sam Roberts <[email protected]>
@BethGriggs BethGriggs mentioned this pull request May 1, 2019
Merged
BethGriggs pushed a commit that referenced this pull request May 10, 2019
@mcollina @BethGriggs
doc: document that stream.on('close') was changed in Node 10
67db596 
See: #25373
See: #18438

PR-URL: #25413
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Sam Roberts <[email protected]>
MylesBorins pushed a commit that referenced this pull request May 16, 2019
@mcollina @MylesBorins
doc: document that stream.on('close') was changed in Node 10
0c33ecb 
See: #25373
See: #18438

PR-URL: #25413
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Sam Roberts <[email protected]>
This was referenced May 29, 2019
Closed
Closed
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vsemozhetbyt vsemozhetbyt vsemozhetbyt left review comments

@BridgeAR BridgeAR BridgeAR approved these changes

@richardlau richardlau richardlau approved these changes

@jasnell jasnell jasnell approved these changes

@sam-github sam-github sam-github approved these changes

@addaleax addaleax Awaiting requested review from addaleax

@mafintosh mafintosh Awaiting requested review from mafintosh

Assignees
No one assigned
Labels
doc Issues and PRs related to the documentations. stream Issues and PRs related to the stream subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@mcollina @nodejs-github-bot @sam-github @jasnell @richardlau @BridgeAR @vsemozhetbyt @BethGriggs