Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: use lowercase for zlib #25371

Closed
wants to merge 1 commit into from
Closed

doc: use lowercase for zlib #25371

wants to merge 1 commit into from

Conversation

Trott
Copy link
Member

@Trott Trott commented Jan 6, 2019

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines

@nodejs-github-bot
Copy link
Collaborator

@Trott build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/2158/pipeline

@nodejs-github-bot nodejs-github-bot added the doc Issues and PRs related to the documentations. label Jan 6, 2019
@addaleax
Copy link
Member

addaleax commented Jan 6, 2019

Does anybody know why Travis CI doesn’t kick off? https://www.traviscistatus.com/ doesn’t seem to show anything. Did we disable it in some way?

@Trott
Copy link
Member Author

Trott commented Jan 7, 2019

Does anybody know why Travis CI doesn’t kick off? https://www.traviscistatus.com/ doesn’t seem to show anything. Did we disable it in some way?

Looks like it stopped working about 7 hours ago, if that gives anyone any ideas.

@addaleax
Copy link
Member

addaleax commented Jan 7, 2019

I’ve (re-?)enabled “Build pushed branches” and “Build pushed pull requests” in https://travis-ci.com/nodejs/node/settings, maybe that’s it. I’d be surprised if one of us had disabled these without telling anybody, though.

@Trott Trott added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Jan 7, 2019
@Trott
Copy link
Member Author

Trott commented Jan 8, 2019

Landed in 005363a

@Trott Trott closed this Jan 8, 2019
Trott added a commit to Trott/io.js that referenced this pull request Jan 8, 2019
@Trott
doc: use lowercase for zlib
005363a 
PR-URL: nodejs#25371
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Vse Mozhet Byt <[email protected]>
Reviewed-By: Daijiro Wachi <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
addaleax pushed a commit that referenced this pull request Jan 9, 2019
@Trott @addaleax
doc: use lowercase for zlib
071f84e 
PR-URL: #25371
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Vse Mozhet Byt <[email protected]>
Reviewed-By: Daijiro Wachi <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
@BridgeAR BridgeAR mentioned this pull request Jan 16, 2019
Merged
BridgeAR pushed a commit to BridgeAR/node that referenced this pull request Jan 16, 2019
@Trott @BridgeAR
doc: use lowercase for zlib
bdde476 
PR-URL: nodejs#25371
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Vse Mozhet Byt <[email protected]>
Reviewed-By: Daijiro Wachi <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
@MylesBorins MylesBorins mentioned this pull request Jan 24, 2019
Merged
BethGriggs pushed a commit that referenced this pull request Apr 28, 2019
@Trott @BethGriggs
doc: use lowercase for zlib
094a7cc 
PR-URL: #25371
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Vse Mozhet Byt <[email protected]>
Reviewed-By: Daijiro Wachi <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
@BethGriggs BethGriggs mentioned this pull request May 1, 2019
Merged
BethGriggs pushed a commit that referenced this pull request May 10, 2019
@Trott @BethGriggs
doc: use lowercase for zlib
32c7038 
PR-URL: #25371
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Vse Mozhet Byt <[email protected]>
Reviewed-By: Daijiro Wachi <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
MylesBorins pushed a commit that referenced this pull request May 16, 2019
@Trott @MylesBorins
doc: use lowercase for zlib
252a696 
PR-URL: #25371
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Vse Mozhet Byt <[email protected]>
Reviewed-By: Daijiro Wachi <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
This was referenced May 29, 2019
Closed
Closed
Closed
Closed
Closed
@sam-github sam-github deleted the Trott-patch-1 branch June 5, 2019 17:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vsemozhetbyt vsemozhetbyt vsemozhetbyt approved these changes

@cjihrig cjihrig cjihrig approved these changes

@watilde watilde watilde approved these changes

@lpinca lpinca lpinca approved these changes

@addaleax addaleax addaleax approved these changes

@jasnell jasnell jasnell approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. doc Issues and PRs related to the documentations.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@Trott @nodejs-github-bot @addaleax @jasnell @lpinca @watilde @cjihrig @vsemozhetbyt