Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: clarify timing of socket.connecting #25333

Closed
wants to merge 1 commit into from
Closed

doc: clarify timing of socket.connecting #25333

wants to merge 1 commit into from

Conversation

sam-github
Copy link
Contributor

@sam-github sam-github commented Jan 4, 2019 •
edited
Loading

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines

@nodejs-github-bot
Copy link
Collaborator

@sam-github build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/2135/pipeline

@nodejs-github-bot nodejs-github-bot added doc Issues and PRs related to the documentations. net Issues and PRs related to the net subsystem. labels Jan 4, 2019
@sam-github sam-github mentioned this pull request Jan 4, 2019
Closed
lpinca
lpinca reviewed Jan 4, 2019
View reviewed changes
doc/api/net.md Outdated Show resolved Hide resolved
vsemozhetbyt
vsemozhetbyt reviewed Jan 4, 2019
View reviewed changes
doc/api/net.md Outdated Show resolved Hide resolved
@sam-github
Copy link
Contributor Author

Removed the "Fixes", since it aparently does not. Still, I think its a small doc improvement, as its a bit more clear.

@sam-github
Copy link
Contributor Author

ci-lite: https://ci.nodejs.org/job/node-test-pull-request-lite-pipeline/2162/ (GREEN)

addaleax
addaleax approved these changes Jan 8, 2019
View reviewed changes
doc/api/net.md Outdated Show resolved Hide resolved
doc/api/net.md Outdated Show resolved Hide resolved
doc/api/net.md Outdated Show resolved Hide resolved
@sam-github
Copy link
Contributor Author

sam-github commented Jan 8, 2019 •
edited
Loading

ci-lite: https://ci.nodejs.org/job/node-test-pull-request-lite-pipeline/2188/

@sam-github sam-github force-pushed the clarify-socket-connecting branch from 464ca30 to 4e2b920 Compare January 8, 2019 18:50
@sam-github
Copy link
Contributor Author

Landed in ccc06a3

@sam-github sam-github closed this Jan 9, 2019
@sam-github sam-github deleted the clarify-socket-connecting branch January 9, 2019 03:55
sam-github added a commit that referenced this pull request Jan 9, 2019
@sam-github
doc: clarify timing of socket.connecting
ccc06a3 
Fixes: #25328

PR-URL: #25333
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Beth Griggs <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
addaleax pushed a commit that referenced this pull request Jan 14, 2019
@sam-github @addaleax
doc: clarify timing of socket.connecting
f3d8639 
Fixes: #25328

PR-URL: #25333
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Beth Griggs <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
@BridgeAR BridgeAR mentioned this pull request Jan 16, 2019
Merged
BridgeAR pushed a commit to BridgeAR/node that referenced this pull request Jan 16, 2019
@sam-github @BridgeAR
doc: clarify timing of socket.connecting
4bc2a4f 
Fixes: nodejs#25328

PR-URL: nodejs#25333
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Beth Griggs <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
@MylesBorins MylesBorins mentioned this pull request Jan 24, 2019
Merged
BethGriggs pushed a commit that referenced this pull request Apr 28, 2019
@sam-github @BethGriggs
doc: clarify timing of socket.connecting
f84317f 
Fixes: #25328

PR-URL: #25333
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Beth Griggs <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
@BethGriggs BethGriggs mentioned this pull request May 1, 2019
Merged
BethGriggs pushed a commit that referenced this pull request May 10, 2019
@sam-github @BethGriggs
doc: clarify timing of socket.connecting
769736c 
Fixes: #25328

PR-URL: #25333
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Beth Griggs <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
MylesBorins pushed a commit that referenced this pull request May 16, 2019
@sam-github @MylesBorins
doc: clarify timing of socket.connecting
ce3cf0d 
Fixes: #25328

PR-URL: #25333
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Beth Griggs <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
This was referenced May 29, 2019
Closed
Closed
This was referenced May 29, 2019
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vsemozhetbyt vsemozhetbyt vsemozhetbyt left review comments

@lpinca lpinca lpinca approved these changes

@BethGriggs BethGriggs BethGriggs approved these changes

@cjihrig cjihrig cjihrig approved these changes

@addaleax addaleax addaleax approved these changes

@jasnell jasnell jasnell approved these changes

Assignees
No one assigned
Labels
doc Issues and PRs related to the documentations. net Issues and PRs related to the net subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@sam-github @nodejs-github-bot @jasnell @addaleax @lpinca @cjihrig @BethGriggs @vsemozhetbyt