-
Notifications
You must be signed in to change notification settings - Fork 30k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
deps: upgrade npm to v6.5.0 #25234
deps: upgrade npm to v6.5.0 #25234
Conversation
Local test failures: not ok 9 - config properties list: projectData: # of elements
---
found: 2
wanted: 0
compare: ===
at:
line: 66
column: 5
file: test/tap/config-basic.js
type: global
function: isDeeplyDetails
stack: |
isDeeplyDetails (test/tap/config-basic.js:66:5)
test/tap/config-basic.js:77:7
Array.forEach (<anonymous>)
test/tap/config-basic.js:76:17
lib/config/core.js:83:7
Array.forEach (<anonymous>)
lib/config/core.js:82:13
f (node_modules/once/once.js:25:25)
finalize (lib/config/core.js:193:5)
afterExtras (lib/config/core.js:184:5)
node_modules/mkdirp/index.js:48:26
source: |
t.is(Object.keys(aa).length, Object.keys(bb).length, msg + ': # of elements')
...
not ok 51 - config by source -> project -> data: # of elements
---
found: 2
wanted: 0
compare: ===
at:
line: 66
column: 5
file: test/tap/config-basic.js
type: global
function: isDeeplyDetails
stack: |
isDeeplyDetails (test/tap/config-basic.js:66:5)
test/tap/config-basic.js:68:5
Array.forEach (<anonymous>)
isDeeplyDetails (test/tap/config-basic.js:67:19)
test/tap/config-basic.js:68:5
Array.forEach (<anonymous>)
isDeeplyDetails (test/tap/config-basic.js:67:19)
test/tap/config-basic.js:79:5
lib/config/core.js:83:7
Array.forEach (<anonymous>)
lib/config/core.js:82:13
f (node_modules/once/once.js:25:25)
finalize (lib/config/core.js:193:5)
afterExtras (lib/config/core.js:184:5)
node_modules/mkdirp/index.js:48:26
source: |
t.is(Object.keys(aa).length, Object.keys(bb).length, msg + ': # of elements')
... |
@ljharb is that test failing on master as well? |
Hmm, I'm seeing many more of the npm tests failing on master - but maybe I'm not running the tests properly. Some help, or independent confirmation, would be appreciated. |
Definitely tests on master are failing. It appears to have been this way for years. I tried to bisect to find out when the last time Going through failures now and seeing about fixing them, but it's going to be slow-going. For example: #22519 (comment) If you're seeing fewer test failures with the newer npm, that's probably a sign that a bunch of things have been fixed. I'd call that success. |
Might be about time to revisit the question of whether we really need npm in our source tree. Sure, we can still huddle it in builds, but having it in the repo likely no longer makes sense (if it ever did). |
In that case, can this land and go out in an 11.6.1? :-D |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
RSLGTM
@Trott any idea why that one FreeBSD job failed? |
Known problem with the test that makes it fail from time to time. Resume Build CI: https://ci.nodejs.org/job/node-test-pull-request/19889/ |
Hmmm...same FreeBSD failure. That's not reassuring. But it seems very unlikely to actually be related. Let's try one more time: https://ci.nodejs.org/job/node-test-pull-request/19890/ ✅ |
Yay, looks like that passed |
This is now 7 days old, has one approval, and a green CI. It can land. However, I'd really like it if it had a second pair of eyes giving it a review. Anyone? @nodejs/npm @lance |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. I had the same failures, plus an additional three due to the fact that I have git configured to sign my commits. Updating my config with commit.gpgsign=false
for deps/npm
seemed to resolve the additional three I was seeing.
Landed in aea5229 |
PR-URL: #25234 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Lance Ball <[email protected]>
PR-URL: #25234 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Lance Ball <[email protected]>
PR-URL: nodejs#25234 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Lance Ball <[email protected]>
PR-URL: nodejs#25234 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Lance Ball <[email protected]>
Notable Changes * compression / zlib: * Added brotli support (Anna Henningsen and Zach Vacura) nodejs#24938 * console: * Added `inspectOptions` option (Ruben Bridgewater) nodejs#24978 * crypto: * Always accept private keys as public keys (Tobias Nießen) nodejs#25217 * deps: * Upgrade npm to v6.5.0 (Jordan Harband) nodejs#25234 * fs: * Use internalBinding('fs') internally instead of process.binding('fs') (Masashi Hirano) nodejs#22478 * http(s): * Support overriding http\\s.globalAgent (Roy Sommer) nodejs#25170 * util: * Inspect ArrayBuffers contents closely (Ruben Bridgewater) nodejs#25006 * worker: * Expose workers by default and remove `--experimental-worker` flag (Anna Henningsen) nodejs#25361 PR-URL: nodejs#25537
Notable Changes * compression / zlib: * Added brotli support (Anna Henningsen and Zach Vacura) #24938 * console: * Added `inspectOptions` option (Ruben Bridgewater) #24978 * crypto: * Always accept private keys as public keys (Tobias Nießen) #25217 * deps: * Upgrade npm to v6.5.0 (Jordan Harband) #25234 * fs: * Use internalBinding('fs') internally instead of process.binding('fs') (Masashi Hirano) #22478 * http(s): * Support overriding http\\s.globalAgent (Roy Sommer) #25170 * util: * Inspect ArrayBuffers contents closely (Ruben Bridgewater) #25006 * worker: * Expose workers by default and remove `--experimental-worker` flag (Anna Henningsen) #25361 PR-URL: #25537
PR-URL: #25234 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Lance Ball <[email protected]>
PR-URL: #25234 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Lance Ball <[email protected]>
I noticed that node v11.6 ships with an
npm
that reports a version ofv6.5.0-next.0
. This PR updates that to actual v6.5.0.Checklist
make test-npm
passes (running now)