src: do not leak NodeTraceStateObserver #25180
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This would otherwise be reported as a memory leak by automated tools.
nodejs-github-bot
added
the
c++
addaleax
added
the
trace_events
richardlau
approved these changes
Dec 22, 2018
|
The crashes look relevant? |
joyeecheung
reviewed
Dec 22, 2018
| @@ -235,6 +237,7 @@ static struct { | |||
| // Destroy tracing after the platform (and platform threads) have been | |||
| // stopped. | |||
| tracing_agent_.reset(nullptr); | |||
| trace_state_observer_.reset(nullptr); | |||
There was a problem hiding this comment.
Should we call controller->RemoveTraceStateObserver(trace_state_observer_.get()) here? (It's currently run in OnTraceEnabled but it may not be ever enabled?)
There was a problem hiding this comment.
I’m not sure, but does the controller still exist at this point?
|
@joyeecheung Thanks for pointing out the failures – afaict it was a double free for the cases where the tracing observer was enabled and cleaned up after itself. It might be nice to keep that behaviour, but I don’t think it’s important… |
joyeecheung
approved these changes
Dec 22, 2018
|
Landed in b4145b8 |
addaleax
added a commit
that referenced
this pull request
Dec 26, 2018
This would otherwise be reported as a memory leak by automated tools. PR-URL: #25180 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Joyee Cheung <[email protected]>
targos
pushed a commit
that referenced
this pull request
Jan 1, 2019
This would otherwise be reported as a memory leak by automated tools. PR-URL: #25180 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Joyee Cheung <[email protected]>
refack
pushed a commit
to refack/node
that referenced
this pull request
Jan 14, 2019
This would otherwise be reported as a memory leak by automated tools. PR-URL: nodejs#25180 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Joyee Cheung <[email protected]>
Merged
Merged
BethGriggs
pushed a commit
that referenced
this pull request
Apr 17, 2019
This would otherwise be reported as a memory leak by automated tools. PR-URL: #25180 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Joyee Cheung <[email protected]>
BethGriggs
pushed a commit
that referenced
this pull request
Apr 28, 2019
This would otherwise be reported as a memory leak by automated tools. PR-URL: #25180 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Joyee Cheung <[email protected]>
Merged
BethGriggs
pushed a commit
that referenced
this pull request
May 10, 2019
This would otherwise be reported as a memory leak by automated tools. PR-URL: #25180 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Joyee Cheung <[email protected]>
MylesBorins
pushed a commit
that referenced
this pull request
May 16, 2019
This would otherwise be reported as a memory leak by automated tools. PR-URL: #25180 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Joyee Cheung <[email protected]>
This was referenced May 29, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This would otherwise be reported as a memory leak by automated tools.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes