-
Notifications
You must be signed in to change notification settings - Fork 30k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
v6.16.0 proposal #25178
v6.16.0 proposal #25178
Conversation
See: #24958 PR-URL: #25036 Reviewed-By: Myles Borins <[email protected]>
This commit adds http_parser_set_max_header_size() to the http-parser for overriding the compile time maximum HTTP header size. Backport-PR-URL: #25173 PR-URL: #24811 Fixes: #24692 Refs: nodejs/http-parser#453 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Myles Borins <[email protected]> Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Сковорода Никита Андреевич <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Jeremiah Senkpiel <[email protected]>
Allow the maximum size of HTTP headers to be overridden from the command line. Backport-PR-URL: #25173 co-authored-by: Matteo Collina <[email protected]> PR-URL: #24811 Fixes: #24692 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Myles Borins <[email protected]> Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Сковорода Никита Андреевич <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Jeremiah Senkpiel <[email protected]>
854cd50
to
a7b8ada
Compare
a7b8ada
to
841c3ea
Compare
The 6.15.0 security release introduced some unexpected breakages on the 6.x release line. This is a special release to fix a regression in the HTTP binary upgrade response body and add a missing CLI flag to adjust the max header size of the http parser. Notable changes: * cli: - add --max-http-header-size flag (cjihrig) #24811 PR-URL: #25178
841c3ea
to
5c2566c
Compare
The 6.15.0 security release introduced some unexpected breakages on the 6.x release line. This is a special release to fix a regression in the HTTP binary upgrade response body and add a missing CLI flag to adjust the max header size of the http parser. Notable changes: * cli: - add --max-http-header-size flag (cjihrig) #24811 PR-URL: #25178
CI: https://ci.nodejs.org/job/node-test-pull-request/19741/ ✅ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
This commit exposes the value of --max-http-header-size as a property of the http module. Backport-PR-URL: #25218 PR-URL: #24860 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Shelley Vohr <[email protected]> Reviewed-By: James M Snell <[email protected]>
5c2566c
to
50eb985
Compare
CI: https://ci.nodejs.org/job/node-test-pull-request/19807/ ✅ |
The 6.15.0 security release introduced some unexpected breakages on the 6.x release line. This is a special release to fix a regression in the HTTP binary upgrade response body and add a missing CLI flag to adjust the max header size of the http parser. Notable changes: * cli: - add --max-http-header-size flag (cjihrig) #24811 * http: - add maxHeaderSize property (cjihrig) #24860 PR-URL: #25178
50eb985
to
a3aa4b4
Compare
The 6.15.0 security release introduced some unexpected breakages on the 6.x release line. This is a special release to fix a regression in the HTTP binary upgrade response body and add a missing CLI flag to adjust the max header size of the http parser. Notable changes: * cli: - add --max-http-header-size flag (cjihrig) #24811 * http: - add maxHeaderSize property (cjihrig) #24860 PR-URL: #25178
The 6.15.0 security release introduced some unexpected breakages on the 6.x release line. This is a special release to fix a regression in the HTTP binary upgrade response body and add a missing CLI flag to adjust the max header size of the http parser. Notable changes: * cli: - add --max-http-header-size flag (cjihrig) nodejs#24811 * http: - add maxHeaderSize property (cjihrig) nodejs#24860 PR-URL: nodejs#25178
2018-12-26, Version 6.16.0 'Boron' (LTS), @MylesBorins
The 6.15.0 security release introduced some unexpected breakages on the 6.x release line.
This is a special release to fix a regression in the HTTP binary upgrade response body and add
a missing CLI flag to adjust the max header size of the http parser.
Notable Changes
Commits
f233b160c9
] - (SEMVER-MINOR) cli: add --max-http-header-size flag (cjihrig) #2481159f83d6896
] - (SEMVER-MINOR) deps: cherry-pick http_parser_set_max_header_size (cjihrig) #24811c0c4de71f0
] - (SEMVER-MINOR) http: add maxHeaderSize property (cjihrig) #248608a3e0c0697
] - http: fix regression of binary upgrade response body (Matteo Collina) #25036